Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

feat: upgraded to node v18, added .nvmrc and updated workflows #122

Merged
merged 1 commit into from
Jun 7, 2023

Conversation

Mashal-m
Copy link
Contributor

@Mashal-m Mashal-m commented Jun 6, 2023

What has changed?

  • Added support for node v18, updated .nvmrc and workflows.
  • Updated frontend-platform, frontend-build, frontend-component-header and frontend-component-footer versions.
  • Resolved respective eslint issues

Ticket
Upgrade Node JS from 16 to 18

edx-internal PR
https://github.com/edx/edx-internal/pull/8531

@github-actions
Copy link

github-actions bot commented Jun 6, 2023

Pull Request Test Coverage Report for Build 5187716069

  • 0 of 4 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.3%) to 54.926%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/App.jsx 0 4 0.0%
Totals Coverage Status
Change from base Build 5179146774: -0.3%
Covered Lines: 168
Relevant Lines: 309

💛 - Coveralls

@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (6d6abe2) 57.64% compared to head (9bf1905) 57.64%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #122   +/-   ##
=======================================
  Coverage   57.64%   57.64%           
=======================================
  Files          26       26           
  Lines         399      399           
  Branches       66       66           
=======================================
  Hits          230      230           
  Misses        153      153           
  Partials       16       16           
Impacted Files Coverage Δ
src/App.jsx 0.00% <0.00%> (ø)
src/console/reducers.js 100.00% <ø> (ø)
src/console/sagas.js 31.16% <ø> (ø)
src/console/utils.js 25.00% <ø> (ø)
src/report/reducers.js 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@alangsto
Copy link
Contributor

alangsto commented Jun 6, 2023

@Mashal-m Thanks for putting another PR together for this - did you have a chance to test this locally? I'm having trouble getting the app to run on my local setup and would like to verify that it renders properly before merging.

@Mashal-m Mashal-m marked this pull request as ready for review June 7, 2023 09:26
@alangsto alangsto merged commit dc8c292 into master Jun 7, 2023
@alangsto alangsto deleted the mashal-m/node18-upgrade branch June 7, 2023 12:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants