This repository has been archived by the owner on Aug 1, 2024. It is now read-only.
feat: Added Opensearch 1.2.0 #925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robrap
reviewed
Apr 26, 2022
| @@ -418,6 +438,7 @@ services: | |||
| - memcached | |||
| - mongo | |||
| - mysql57 | |||
| - opensearch12 | |||
There was a problem hiding this comment.
- Can you update the PR description with a little more background about how and when each of the services will rely on this?
- Will this just be needed for a rare use case? I’m not clear on what “test OS upgrades” entails, but it seems like a more rare activity and that maybe this isn’t a required dependency for most uses of LMS or other services? This is a question. If not, maybe there should simply be doc changes for when and how to bring this container up?
There was a problem hiding this comment.
I think the best reference for this is the Elasticsearch -> OpenSearch ticket we have on the DEPR board. We are migrating all our services off Elasticsearch and for those that can't use MySQL full text search, we're going to use OpenSearch. openedx/public-engineering#16
There was a problem hiding this comment.
Yeah, we are migrating LMS, studio, cs_comments(forum), and blockstore from Elasticsearch -> OpenSearch.
There was a problem hiding this comment.
Ok. Seems fine if you think we need both dependencies now.
robrap
approved these changes
Apr 26, 2022
syedimranhassan
force-pushed
the
ihassan/added_opensearch_1_2_0
branch
from
5ceae31
to
4e08941
Compare
nsprenkle
pushed a commit
that referenced
this pull request
Nov 21, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://openedx.atlassian.net/browse/ISRE-1306
Adding OpenSearch for LMS, studio, cs_comments, and blockstore.
Our plan is to replace ES with OS for these services.
I've completed each of the following or determined they are not applicable: