Skip to content
This repository has been archived by the owner on Aug 1, 2024. It is now read-only.

feat: remove JWT_AUTH_REFRESH_COOKIE depr190 #1211

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

Yagnesh1998
Copy link
Contributor

Description:
The setting JWT_AUTH_REFRESH_COOKIE is meaningless and unused and should be cleaned up to avoid confusion.
In the very early days of introducing MFEs, we thought we were going to need this cookie in addition to the JWT cookie. However, it turned out we didn't need it, but the setting stuck around the contagion of it (being in cookiecutter and other template libraries) has resulted in it uselessly being copied to many repos.

Supporting information:
as per the original ticket openedx/public-engineering#190, this setting is removed.

Rationale
The setting JWT_AUTH_REFRESH_COOKIE is meaningless and unused, and should be cleaned up to avoid confusion.

In the very early days of introducing MFEs, we thought we were going to need this cookie in addition to the JWT cookie. However, it turned out we didn't need it, but the setting stuck around the contagion of it (being in cookiecutter and other template libraries) has resulted in it uselessly being copied to many repos.

Removal
The setting JWT_AUTH_REFRESH_COOKIE can simply be removed with no ramifications.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 17, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @Yagnesh1998! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@itsjeyd
Copy link

itsjeyd commented Oct 17, 2023

Hi @Yagnesh1998, thank you for this contribution! I'm lining the changes up for a test run.

@itsjeyd itsjeyd added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Oct 17, 2023
@robrap robrap merged commit 0ffb265 into openedx-unsupported:master Oct 17, 2023
12 checks passed
@openedx-webhooks
Copy link

@Yagnesh1998 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@e0d e0d removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Oct 17, 2023
@Yagnesh1998 Yagnesh1998 deleted the edx-depr190 branch October 18, 2023 05:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants