Skip to content
This repository has been archived by the owner on May 6, 2024. It is now read-only.

feat: Remove JWT_AUTH_REFRESH_COOKIE #7042

Merged
merged 1 commit into from
Oct 11, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion docker/build/enterprise_catalog/enterprise_catalog.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ EXTRA_APPS: []
JWT_AUTH:
JWT_AUTH_COOKIE_HEADER_PAYLOAD: edx-jwt-cookie-header-payload
JWT_AUTH_COOKIE_SIGNATURE: edx-jwt-cookie-signature
JWT_AUTH_REFRESH_COOKIE: edx-jwt-refresh-cookie
JWT_ISSUERS:
- AUDIENCE: lms-key
ISSUER: http://localhost:18000/oauth2
Expand Down
1 change: 0 additions & 1 deletion playbooks/roles/common_vars/defaults/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,6 @@ COMMON_JWT_PUBLIC_SIGNING_JWK_SET: ''

COMMON_JWT_AUTH_COOKIE_HEADER_PAYLOAD: 'edx-jwt-cookie-header-payload'
COMMON_JWT_AUTH_COOKIE_SIGNATURE: 'edx-jwt-cookie-signature'
COMMON_JWT_AUTH_REFRESH_COOKIE: 'edx-jwt-refresh-cookie'

# To be deprecated, in favor of the above COMMON_JWT_PUBLIC_SIGNING_JWK_SET.
COMMON_JWT_SECRET_KEY: 'SET-ME-PLEASE'
Expand Down
1 change: 0 additions & 1 deletion playbooks/roles/ecommerce/defaults/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,6 @@ ecommerce_config:
JWT_PUBLIC_SIGNING_JWK_SET: '{{ COMMON_JWT_PUBLIC_SIGNING_JWK_SET|string }}'
JWT_AUTH_COOKIE_HEADER_PAYLOAD: '{{ COMMON_JWT_AUTH_COOKIE_HEADER_PAYLOAD }}'
JWT_AUTH_COOKIE_SIGNATURE: '{{ COMMON_JWT_AUTH_COOKIE_SIGNATURE }}'
JWT_AUTH_REFRESH_COOKIE: '{{ COMMON_JWT_AUTH_REFRESH_COOKIE }}'

EDX_DRF_EXTENSIONS: '{{ ECOMMERCE_EDX_DRF_EXTENSIONS }}'

Expand Down
1 change: 0 additions & 1 deletion playbooks/roles/edx_django_service/defaults/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,6 @@ edx_django_service_jwt_auth:
JWT_PUBLIC_SIGNING_JWK_SET: '{{ COMMON_JWT_PUBLIC_SIGNING_JWK_SET|string }}'
JWT_AUTH_COOKIE_HEADER_PAYLOAD: '{{ COMMON_JWT_AUTH_COOKIE_HEADER_PAYLOAD }}'
JWT_AUTH_COOKIE_SIGNATURE: '{{ COMMON_JWT_AUTH_COOKIE_SIGNATURE }}'
JWT_AUTH_REFRESH_COOKIE: '{{ COMMON_JWT_AUTH_REFRESH_COOKIE }}'

edx_django_service_extra_apps: []

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,6 @@ edx_django_service_with_rendered_config_jwt_auth:
JWT_PUBLIC_SIGNING_JWK_SET: '{{ COMMON_JWT_PUBLIC_SIGNING_JWK_SET|string }}'
JWT_AUTH_COOKIE_HEADER_PAYLOAD: '{{ COMMON_JWT_AUTH_COOKIE_HEADER_PAYLOAD }}'
JWT_AUTH_COOKIE_SIGNATURE: '{{ COMMON_JWT_AUTH_COOKIE_SIGNATURE }}'
JWT_AUTH_REFRESH_COOKIE: '{{ COMMON_JWT_AUTH_REFRESH_COOKIE }}'

edx_django_service_with_rendered_config_extra_apps: []

Expand Down
1 change: 0 additions & 1 deletion playbooks/roles/edx_notes_api/defaults/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,6 @@ edx_notes_api_service_config:
JWT_PUBLIC_SIGNING_JWK_SET: '{{ COMMON_JWT_PUBLIC_SIGNING_JWK_SET|string }}'
JWT_AUTH_COOKIE_HEADER_PAYLOAD: '{{ COMMON_JWT_AUTH_COOKIE_HEADER_PAYLOAD }}'
JWT_AUTH_COOKIE_SIGNATURE: '{{ COMMON_JWT_AUTH_COOKIE_SIGNATURE }}'
JWT_AUTH_REFRESH_COOKIE: '{{ COMMON_JWT_AUTH_REFRESH_COOKIE }}'
USERNAME_REPLACEMENT_WORKER: "{{ EDX_NOTES_USERNAME_REPLACEMENT_WORKER }}"

#
Expand Down
2 changes: 0 additions & 2 deletions playbooks/roles/edxapp/defaults/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -434,7 +434,6 @@ EDXAPP_JWT_SECRET_KEY: "{{ COMMON_JWT_SECRET_KEY }}"
EDXAPP_JWT_PUBLIC_SIGNING_JWK_SET: "{{ COMMON_JWT_PUBLIC_SIGNING_JWK_SET|string }}"
EDXAPP_JWT_AUTH_COOKIE_HEADER_PAYLOAD: '{{ COMMON_JWT_AUTH_COOKIE_HEADER_PAYLOAD }}'
EDXAPP_JWT_AUTH_COOKIE_SIGNATURE: '{{ COMMON_JWT_AUTH_COOKIE_SIGNATURE }}'
EDXAPP_JWT_AUTH_REFRESH_COOKIE: '{{ COMMON_JWT_AUTH_REFRESH_COOKIE }}'

# See https://github.com/openedx/edx-platform/blob/master/openedx/core/djangoapps/oauth_dispatch/docs/decisions/0008-use-asymmetric-jwts.rst
EDXAPP_JWT_SIGNING_ALGORITHM: !!null
Expand Down Expand Up @@ -1429,7 +1428,6 @@ generic_env_config: &edxapp_generic_env
JWT_PRIVATE_SIGNING_JWK: "{{ EDXAPP_JWT_PRIVATE_SIGNING_JWK|string }}"
JWT_AUTH_COOKIE_HEADER_PAYLOAD: "{{ EDXAPP_JWT_AUTH_COOKIE_HEADER_PAYLOAD }}"
JWT_AUTH_COOKIE_SIGNATURE: "{{ EDXAPP_JWT_AUTH_COOKIE_SIGNATURE }}"
JWT_AUTH_REFRESH_COOKIE: "{{ EDXAPP_JWT_AUTH_REFRESH_COOKIE }}"

# edx-rbac Setting
SYSTEM_WIDE_ROLE_CLASSES: "{{ EDXAPP_SYSTEM_WIDE_ROLE_CLASSES }}"
Expand Down
1 change: 0 additions & 1 deletion util/helm_values_to_rst_table_util/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ Example:
app.config.HAYSTACK_CONNECTIONS.default.URL TODO http://notes-elasticsearch-client:9200/
app.config.JWT_AUTH.JWT_AUTH_COOKIE_HEADER_PAYLOAD TODO stage-edx-jwt-cookie-header-payload
app.config.JWT_AUTH.JWT_AUTH_COOKIE_SIGNATURE TODO stage-edx-jwt-cookie-signature
app.config.JWT_AUTH.JWT_AUTH_REFRESH_COOKIE TODO stage-edx-jwt-refresh-cookie
app.config.JWT_AUTH.JWT_ISSUERS TODO []
app.config.JWT_AUTH.JWT_PUBLIC_SIGNING_JWK_SET TODO
app.config.RESULTS_DEFAULT_SIZE TODO 25
Expand Down
Loading