fix(nexus): don't persist if child faults during nexus create #1780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When nexus is being created with a single child, and that child goes into retire path before nexus is open, then the child gets persisted as unhealthy. This will cause volume to never be able to attach later on. Signed-off-by: Diwakar Sharma <diwakar.sharma@datacore.com>
dsharma-dc
requested review from
datacore-chackett and
tiagolobocastro
and removed request for
datacore-chackett
|
bors try |
tiagolobocastro
approved these changes
Dec 10, 2024
tryBuild succeeded: |
Abhinandan-Purkait
approved these changes
Dec 10, 2024
|
bors merge |
|
Build succeeded: |
bors-openebs-mayastor bot
pushed a commit
that referenced
this pull request
Dec 11, 2024
1782: Cherry pick PR #1780 r=dsharma-dc a=dsharma-dc When nexus is being created with a single child, and that child goes into retire path before nexus is open, then the child gets persisted as unhealthy. This will cause volume to never be able to attach later on. Co-authored-by: Diwakar Sharma <diwakar.sharma@datacore.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When nexus is being created with a single child, and that child goes into retire path before nexus is open, then the child gets persisted as unhealthy. This will cause volume to never be able to attach later on.