fix(upgrade-job): remove short args to resolve conflict over '-h' option #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two clap args introduced in #330 make use the short form option argument. These two arguments -- 'helm_args_set' and 'helm_args_set_file' begin with 'h'. Both of these two args, as well the '--help' option try to make use of '-h'. This change removes the short form arg for these two args. Signed-off-by: Niladri Halder <niladri.halder26@gmail.com>
niladrih
requested review from
tiagolobocastro,
sinhaashish,
Abhinandan-Purkait,
datacore-vvarakantham,
abhilashshetty04 and
dsharma-dc
sinhaashish
approved these changes
Oct 9, 2023
dsharma-dc
approved these changes
Oct 9, 2023
tiagolobocastro
approved these changes
Oct 9, 2023
Yuss 💯 |
|
bors merge |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two clap args introduced in #330 make use the short form option argument. These two arguments -- 'helm_args_set' and 'helm_args_set_file' begin with 'h'. Both of these two args, as well the '--help' option try to make use of '-h'. This change removes the short form arg for these two args.
Remove short args for 'helm_args_set' and 'helm_args_set_file' CliArgs.
Description
Motivation and Context
upgrade-job -hfails.Regression
Yes.
Fixes a regression introduced in #330
How Has This Been Tested?
Trivial change, tested the successful execution of
upgrade-job -h.