Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick #337 to release/2.4 branch #338

Merged
merged 1 commit into from
Sep 4, 2023
Merged

Cherry-pick #337 to release/2.4 branch #338

merged 1 commit into from
Sep 4, 2023

Conversation

niladrih
Copy link
Member

@niladrih niladrih commented Sep 4, 2023

This cherry-picks the commits from the following PRs(s):

@niladrih
fix(upgrade-job): set defaults for absent helm values
a603a31 
Signed-off-by: Niladri Halder <niladri.halder26@gmail.com>
@niladrih niladrih changed the title fix(upgrade-job): set defaults for absent helm values Cherryy-pick #337 to release/2.4 branch Sep 4, 2023
@niladrih niladrih changed the title Cherryy-pick #337 to release/2.4 branch Cherry-pick #337 to release/2.4 branch Sep 4, 2023
avishnu
avishnu approved these changes Sep 4, 2023
View reviewed changes
Copy link
Member

@avishnu avishnu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Abhinandan-Purkait
Abhinandan-Purkait approved these changes Sep 4, 2023
View reviewed changes
Copy link
Member

@Abhinandan-Purkait Abhinandan-Purkait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@niladrih
Copy link
Member Author

niladrih commented Sep 4, 2023

bors merge

@bors
Copy link
Contributor

bors bot commented Sep 4, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit f03fc58 into release/2.4 Sep 4, 2023
@bors bors bot deleted the snapshotterTag-cherry branch September 4, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Abhinandan-Purkait Abhinandan-Purkait Abhinandan-Purkait approved these changes

@sinhaashish sinhaashish sinhaashish approved these changes

@avishnu avishnu avishnu approved these changes

@abhilashshetty04 abhilashshetty04 Awaiting requested review from abhilashshetty04

@w3aman w3aman Awaiting requested review from w3aman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@niladrih @avishnu @sinhaashish @Abhinandan-Purkait