fix(kubectl-plugin): non-zero exit code on error #694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datacore-vvarakantham
requested review from
tiagolobocastro and
Abhinandan-Purkait
Abhinandan-Purkait
approved these changes
Dec 4, 2023
There was a problem hiding this comment.
Should it be rather a wrapper function which logs an error message and returns an exit code, rather than calling exit everywhere. In that way we can reuse the same method? @tiagolobocastro wdyt?
datacore-vvarakantham
force-pushed
the
kubectl-plugin-exit-code
branch
from
69447b3 to
be05c74
Compare
hmm yeah... |
datacore-vvarakantham
force-pushed
the
kubectl-plugin-exit-code
branch
from
be05c74 to
4ba2a71
Compare
datacore-vvarakantham
force-pushed
the
kubectl-plugin-exit-code
branch
from
4ba2a71 to
06cc4d1
Compare
tiagolobocastro
approved these changes
Dec 8, 2023
datacore-vvarakantham
force-pushed
the
kubectl-plugin-exit-code
branch
from
06cc4d1 to
ff1c9ae
Compare
Signed-off-by: Vandana Varakantham <vandana.varakantham@datacore.com>
datacore-vvarakantham
force-pushed
the
kubectl-plugin-exit-code
branch
from
ff1c9ae to
ad86b3a
Compare
|
bors merge |
bors-openebs-mayastor bot
pushed a commit
that referenced
this pull request
Dec 11, 2023
694: fix(kubectl-plugin): non-zero exit code on error r=datacore-vvarakantham a=datacore-vvarakantham Returning non zero exit code with an error from plugin with kubectl command. Co-authored-by: Vandana Varakantham <vandana.varakantham@datacore.com>
|
Build failed: |
|
bors merge |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Returning non zero exit code with an error from plugin with kubectl command.