Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the tolerations on jiva deployments #381

Merged
merged 1 commit into from
Jun 29, 2018
Merged

Update the tolerations on jiva deployments #381

merged 1 commit into from
Jun 29, 2018

Conversation

kmova
Copy link
Contributor

@kmova kmova commented Jun 29, 2018

Signed-off-by: kmova kiran.mova@openebs.io

What this PR does / why we need it:
The jiva controller and replica deployments use node tolerations that specify if the pod should be evicted or retained on the node. The node toleration labels have changed with the recent k8s version and a few new ones have been added. This PR addes the new tolerations that apply to jiva controller and replica deployments.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Signed-off-by: kmova <kiran.mova@openebs.io>
Copy link
Contributor

@prateekpandey14 prateekpandey14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link

codecov bot commented Jun 29, 2018

Codecov Report

Merging #381 into master will increase coverage by 0.45%.
The diff coverage is 76.92%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #381      +/-   ##
==========================================
+ Coverage   28.92%   29.37%   +0.45%     
==========================================
  Files          65       65              
  Lines        5462     5514      +52     
==========================================
+ Hits         1580     1620      +40     
- Misses       3708     3720      +12     
  Partials      174      174
Impacted Files Coverage Δ
orchprovider/k8s/v1/k8s.go 34.75% <76.92%> (+2.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18614ad...6ac1d86. Read the comment docs.

@AmitKumarDas AmitKumarDas merged commit 8acd08b into openebs-archive:master Jun 29, 2018
@kmova
Copy link
Contributor Author

kmova commented Jun 29, 2018

The new tolerations on controller and replica pods are as shown below:

Controller:

  tolerations:
  - effect: NoExecute
    key: node.alpha.kubernetes.io/notReady
    operator: Exists
    tolerationSeconds: 0
  - effect: NoExecute
    key: node.alpha.kubernetes.io/unreachable
    operator: Exists
    tolerationSeconds: 0
  - effect: NoExecute
    key: node.kubernetes.io/not-ready
    operator: Exists
    tolerationSeconds: 0
  - effect: NoExecute
    key: node.kubernetes.io/unreachable
    operator: Exists
    tolerationSeconds: 0

Replica:

  tolerations:
  - effect: NoExecute
    key: node.alpha.kubernetes.io/notReady
    operator: Exists
  - effect: NoExecute
    key: node.alpha.kubernetes.io/unreachable
    operator: Exists
  - effect: NoExecute
    key: node.kubernetes.io/not-ready
    operator: Exists
  - effect: NoExecute
    key: node.kubernetes.io/unreachable
    operator: Exists
  - effect: NoExecute
    key: node.kubernetes.io/out-of-disk
    operator: Exists
  - effect: NoExecute
    key: node.kubernetes.io/memory-pressure
    operator: Exists
  - effect: NoExecute
    key: node.kubernetes.io/disk-pressure
    operator: Exists
  - effect: NoExecute
    key: node.kubernetes.io/network-unavailable
    operator: Exists
  - effect: NoExecute
    key: node.kubernetes.io/unschedulable
    operator: Exists
  - effect: NoExecute
    key: node.cloudprovider.kubernetes.io/uninitialized
    operator: Exists

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants