Add ENV variables to specify default node selectors #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR has been tested using a custom m-apiserver image (openebs/m-apiserver:0.6-ns-dev) built with the changes specified in this PR. Tested this by creating a 5 node cluster in the following way: (b) Labelled one more node with nodetype=storage. The pending replica's now got scheduled onthe newly labelled node. |
|
@kmova The UT code needs to mock the new interfaces that are created... |
Signed-off-by: kmova <kiran.mova@openebs.io>
Codecov Report
@@ Coverage Diff @@
## master #372 +/- ##
==========================================
+ Coverage 28.86% 28.95% +0.08%
==========================================
Files 65 65
Lines 5428 5457 +29
==========================================
+ Hits 1567 1580 +13
- Misses 3694 3706 +12
- Partials 167 171 +4
Continue to review full report at Codecov.
|
|
Looks good, can you please paste the generated deployment yaml spec of controller and replica. |
|
Controller Deployment of a Running Volume: |
|
Replica Deployment: |
|
Thanks @AmitKumarDas, @prateekpandey14 for quick reviews!
|
AmitKumarDas
approved these changes
Jun 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: kmova kiran.mova@openebs.io
What this PR does / why we need it:
This PR allows the administrators to specify the nodes on which the OpenEBS Replica and Controller Pods have to be scheduled using Kubernetes "NodeSelector" option. While Taints/Tolerations also can be used for this purpose, "NodeSelectors" are much simpler to setup using the node labels. And an added advantage is that - this can be done without having to worry about pushing taints to non-storage nodes.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
The implementation follows the traditional approach of specifying an ENV variable similar to how taints and tolerations are specified. This code is required only till the CAS Templates feature is available.