Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webhook): fix version comparison of webhook resources #1806

Merged
merged 1 commit into from
Jun 14, 2021

Conversation

shubham14bajpai
Copy link
Contributor

Signed-off-by: shubham shubham.bajpai@mayadata.io

What this PR does?:

This PR fixes the issue where the validatingwebhookconfiguration did not get updated the upgrading from 1.12.0 to latest versions.

failed to patch cspc cstor-cspc-disk-pool: Internal error occurred: failed calling webhook "admission-webhook.cstor.openebs.io": converting (v1.AdmissionReview) to (v1beta1.AdmissionReview): unknown conversion

Does this PR require any upgrade changes?:

If the changes in this PR are manually verified, list down the scenarios covered::

Any additional information for your reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs

Checklist:

  • Fixes #
  • PR Title follows the convention of <type>(<scope>): <subject>
  • Has the change log section been updated?
  • Commit has unit tests
  • Commit has integration tests
  • (Optional) Are upgrade changes included in this PR? If not, mention the issue/PR to track:
  • (Optional) If documentation changes are required, which issue on https://github.com/openebs/openebs-docs is used to track them:

Signed-off-by: shubham <shubham.bajpai@mayadata.io>
@prateekpandey14 prateekpandey14 merged commit 860d723 into openebs-archive:master Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants