Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(replica): add logs for io timeout in replica #186

Merged
merged 2 commits into from
Feb 19, 2019

Conversation

utkarshmani1997
Copy link
Contributor

@utkarshmani1997 utkarshmani1997 commented Feb 19, 2019

Recently we have observed that controller was logging an error
if io timeout happened but in replica there was no sign of such
error. So log has been added to replica also which compare the
the time took for the request to complete with the operation timeout
and print logs if required.

Log message:

time="2019-02-19T14:17:45Z" level=warning msg="Write time: 20.001869975s greater than write timeout: 15s at controller" 

Closes issue: openebs/openebs#2398

Signed-off-by: Utkarsh Mani Tripathi utkarsh.tripathi@mayadata.io

@payes payes requested review from payes and kmova February 19, 2019 06:03
    Recently we have observed that controller was logging an error
    if io timeout happened but in replica there was no sign of such
    error. So log has been added to replica also which compare the
    the time took for the request to complete with the operation timeout
    and print logs if required.

Signed-off-by: Utkarsh Mani Tripathi <utkarsh.tripathi@mayadata.io>
@utkarshmani1997 utkarshmani1997 force-pushed the io-timeout-log branch 3 times, most recently from a99f98a to e5f90aa Compare February 19, 2019 13:52
Signed-off-by: Utkarsh Mani Tripathi <utkarsh.tripathi@mayadata.io>
Copy link
Contributor

@payes payes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@payes payes merged commit 8044de1 into openebs-archive:master Feb 19, 2019
utkarshmani1997 added a commit to utkarshmani1997/jiva that referenced this pull request Feb 20, 2019
* fix(replica): add logs for io timeout in replica

    Recently we have observed that controller was logging an error
    if io timeout happened but in replica there was no sign of such
    error. So log has been added to replica also which compare the
    the time took for the request to complete with the operation timeout
    and print logs if required.

Signed-off-by: Utkarsh Mani Tripathi <utkarsh.tripathi@mayadata.io>
payes pushed a commit that referenced this pull request Feb 20, 2019
* fix(replica): add logs for io timeout in replica

    Recently we have observed that controller was logging an error
    if io timeout happened but in replica there was no sign of such
    error. So log has been added to replica also which compare the
    the time took for the request to complete with the operation timeout
    and print logs if required.

Signed-off-by: Utkarsh Mani Tripathi <utkarsh.tripathi@mayadata.io>
@utkarshmani1997 utkarshmani1997 deleted the io-timeout-log branch July 16, 2019 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants