Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/pdf export #185

Merged
merged 2 commits into from
Nov 12, 2024
Merged

Fix/pdf export #185

merged 2 commits into from
Nov 12, 2024

Conversation

jurgenbelien
Copy link
Collaborator

Dependency issues result in our Netlify function being unable to save the html to pdf with headless Chromium. Easiest way to restore this functionality is letting the user use the print dialog in their browser.

@jurgenbelien jurgenbelien marked this pull request as ready for review November 1, 2024 13:00
@jurgenbelien jurgenbelien requested a review from IoannaMi November 1, 2024 13:39
Copy link

@IoannaMi IoannaMi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code quality looks good, but I haven't tested the functionality locally.

@jurgenbelien jurgenbelien merged commit 8e5fa65 into development Nov 12, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants