lomax: Adding coroutine functionality #76
Conversation
lomax can now be parllelized with go coroutines! Signed-off-by: Simarpreet Singh <simar@opendns.com>
Signed-off-by: Simarpreet Singh <simar@opendns.com>
|
|
||
| while true | ||
| do | ||
| pkill -9 "lomax"; |
There was a problem hiding this comment.
What's the purpose of this script? "kill-all.sh" sounds like it should just shut lomax down, but in fact it spins in a loop (consuming 100% CPU most likely) and repeatedly kills it. If this behavior is intended it would be good to have a comment explaining its purpose—just a sentence or two would suffice.
There was a problem hiding this comment.
lomax/scripts/stress-test-1.sh could potentially spawn a lot of lomax instances depending on the argument passed in. This may get out of control if the system can't handle it. The reason I wrote this is because this allows anything "lomax" to be killed without any wait. Is there's a better way to do the above use case?
|
I'll improve on the kill-all.sh script once I merge this in as it's needed elsewhere. |
lomax: Adding coroutine functionality
Signed-off-by: Simarpreet Singh simar@opendns.com