Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading node_modules #1

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

howlingsails
Copy link

Trying to upgrade packages to latest versions for package users.

Fixing issues
package.json Outdated
@@ -1,6 +1,6 @@
{
"name": "@opendnd/core",
"version": "0.2.7",
"name": "@howlingsails-dnd-core",
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm change this for publishing for validation in high projects for now

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what this means but cannot merge this if it changes the package name.

"env:dev": "cross-env NODE_ENV=development",
"env:prod": "cross-env NODE_ENV=production",
"test": "mocha -c -S -R spec --compilers ts:ts-node/register --check-leaks",
"test": "mocha -c -S -R spec ts:ts-node/register --check-leaks",
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't work on the master branch..

@howlingsails howlingsails marked this pull request as draft November 6, 2022 06:41
Copy link
Author

@howlingsails howlingsails left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First Cleanup

@howlingsails howlingsails marked this pull request as ready for review November 6, 2022 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants