This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Fix workbench issue in backported 1.11 branch: error message cannot display #943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }; | ||
| } | ||
|
|
||
| // response: IHttpResponse<ResponseData> |
There was a problem hiding this comment.
Do we need to leave these comments in?
There was a problem hiding this comment.
Yes I added this comment here to remind us that the responses of success and error are of different types
davidcui1225
approved these changes
Dec 16, 2020
penghuo
approved these changes
Dec 16, 2020
joshuali925
approved these changes
Dec 16, 2020
joshuali925
reviewed
Dec 16, 2020
| @@ -251,7 +251,8 @@ export class Main extends React.Component<MainProps, MainState> { | |||
| }; | |||
| } | |||
|
|
|||
| processQueryResponse(response: IHttpResponse<ResponseData>): ResponseDetail<string> { | |||
| processQueryResponse(response: any): ResponseDetail<string> { | |||
| console.log(response) | |||
There was a problem hiding this comment.
unnecessary console.log?
Codecov Report
@@ Coverage Diff @@
## opendistro-1.11-rc3 #943 +/- ##
======================================================
Coverage 99.86% 99.86%
Complexity 2320 2320
======================================================
Files 230 230
Lines 5337 5337
Branches 346 346
======================================================
Hits 5330 5330
Misses 5 5
Partials 2 2 Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Before:
After:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.