-
Notifications
You must be signed in to change notification settings - Fork 186
add string function RIGHT #938
add string function RIGHT #938
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #938 +/- ##
==========================================
Coverage 99.86% 99.86%
- Complexity 2315 2337 +22
==========================================
Files 230 232 +2
Lines 5329 5383 +54
Branches 346 350 +4
==========================================
+ Hits 5322 5376 +54
Misses 5 5
Partials 2 2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes! Could you check if we can add comparison test now? https://github.com/opendistro-for-elasticsearch/sql/tree/develop/integ-test/src/test/resources/correctness/expressions
I recall there was some issue adding text function. I think it's doable now?
could you also add the doc for PPL? https://github.com/opendistro-for-elasticsearch/sql/blob/develop/docs/experiment/ppl/functions/string.rst |
Thanks. added comparison test. |
Thanks. added this change. |
* add right function * update doc * address PR comments * fix build failure Co-authored-by: Rupal Mahajan <>
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.