This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
add fix to handle functions applied to literal #913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 10, 2020 14:24
Codecov Report
@@ Coverage Diff @@
## develop #913 +/- ##
===========================================
Coverage 99.85% 99.86%
- Complexity 2149 2251 +102
===========================================
Files 216 229 +13
Lines 4851 5204 +353
Branches 323 342 +19
===========================================
+ Hits 4844 5197 +353
Misses 5 5
Partials 2 2 Continue to review full report at Codecov.
|
dai-chen
reviewed
Dec 11, 2020
...rc/main/java/com/amazon/opendistroforelasticsearch/sql/sql/parser/AstAggregationBuilder.java
Outdated
Show resolved
Hide resolved
dai-chen
reviewed
Dec 11, 2020
integ-test/src/test/java/com/amazon/opendistroforelasticsearch/sql/sql/DateTimeFunctionIT.java
Show resolved
Hide resolved
dai-chen
approved these changes
Dec 14, 2020
Sure, will remove it. |
chloe-zh
approved these changes
Dec 14, 2020
penghuo
pushed a commit
that referenced
this pull request
Dec 15, 2020
* add functions with literal * address PR comments * remove unnecessary check. anyMatch returns false for empty list. * remove isNonLiteral() Co-authored-by: Rupal Mahajan <>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #899
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.