Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Add PPL enable/disable setting #681

Merged

Conversation

penghuo
Copy link
Contributor

@penghuo penghuo commented Aug 13, 2020

Description of changes:

  1. add the ppl feature enable/disable feature.
    https://github.com/penghuo/sql/blob/pr-ppl-disable-settings/docs/experiment/ppl/admin/settings.rst#opendistro-ppl-enabled
  2. enhance the error response message by follow the existing SQL procedure.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@penghuo penghuo changed the title Pr ppl enable settings Add PPL enable/disable setting Aug 13, 2020
@penghuo penghuo added the PPL label Aug 13, 2020
@penghuo penghuo marked this pull request as ready for review August 13, 2020 18:31
Copy link
Member

@chloe-zh chloe-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the changes!

@penghuo penghuo merged commit fb251cf into opendistro-for-elasticsearch:develop Aug 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants