Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Add plugin setting for new SQL module #544

Conversation

dai-chen
Copy link
Member

@dai-chen dai-chen commented Jun 30, 2020

Issue #, if available: #543

Description of changes: Add a plugin setting so user can choose to disable new SQL parser and engine if any issue found.

  1. The setting is false (new query engine disabled) by default: This is temporary during this transition period. The new engine will be enabled by default in near future: https://github.com/dai-chen/sql/blob/add-new-sql-module-setting/docs/user/admin/settings.rst#opendistro-sql-engine-new-enabled
  2. Add a note paragraph in new docs to remind user to enable new engine beforehand: https://github.com/dai-chen/sql/blob/add-new-sql-module-setting/docs/user/dql/expressions.rst
  3. Enable new engine before comparison test and other IT in integ-test and doc in doctest (by a temporary doc).

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@dai-chen dai-chen added enhancement New feature or request SQL labels Jun 30, 2020
@dai-chen dai-chen self-assigned this Jun 30, 2020
@dai-chen dai-chen marked this pull request as ready for review July 6, 2020 21:45
Copy link
Contributor

@penghuo penghuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@chloe-zh chloe-zh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adding the setting!

@dai-chen dai-chen merged commit bd379cf into opendistro-for-elasticsearch:develop Jul 8, 2020
@dai-chen dai-chen deleted the add-new-sql-module-setting branch July 8, 2020 18:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request SQL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants