This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Add select expression without query support #542
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #545, #264, #256
Description of changes: Recently a new SQL module was added and integrate with new query engine. As first feature, select literal without query (FROM clause) was supported. In this PR, support for more expression selected without query is added to lay the foundation for future SQL functions work. In particular, the changes include:
SELECT 1 + 2
SELECT abs(-1)
Out of scope: Only one function
abs
is added in this PR as a sample. More functions and other expression such as predicate expression will be covered in future PR separately.Testing: As comparison test framework is enable by default, new test convention is followed:
arithmetics.txt
andfunctions.txt
ExpressionIT
to test edge case like divide by zeroDocumentation: Add one doc in doctest https://github.com/dai-chen/sql/blob/add-select-expression-support/docs/user/dql/expressions.rst#arithmetic-expressions.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.