This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Support LIKE operator #534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dai-chen
reviewed
Jun 26, 2020
dai-chen
reviewed
Jun 26, 2020
...c/main/java/com/amazon/opendistroforelasticsearch/sql/expression/operator/OperatorUtils.java
Outdated
Show resolved
Hide resolved
dai-chen
reviewed
Jun 26, 2020
...on/opendistroforelasticsearch/sql/expression/operator/predicate/BinaryPredicateOperator.java
Outdated
Show resolved
Hide resolved
Thanks @dai-chen ! The doc of operators have not been created/updated, can I add the doc test when adding the experimental doc in another PR? |
Sure, no problem! Next time probably we can start from doc to drive the coding and save the trouble of adding all docs at last. :) |
# Conflicts: # core/src/main/java/com/amazon/opendistroforelasticsearch/sql/expression/DSL.java
penghuo
reviewed
Jun 30, 2020
|
|
||
| private static final char DEFAULT_ESCAPE = '\\'; | ||
|
|
||
| private static String patternToRegex(String patternString) { |
There was a problem hiding this comment.
- could you seperate it from OperatorUtils in case is more focus on SQL regex to Java regex.
- by define the ESCAPE is defined in SQL language, how do we support it?
- is it possible to seperate the translation rule from translation logic.
for example,
TranslationRule.Buidler.put("//%", %").put("%", ".*").build()
Then, apply rule on the input REGEX.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Syntax:
string like patternThe pattern supports string literal with percent(
%) character for wildcard and underscore(_) character for single character. Here are some examples:foobar like 'foobar%'-> truefoobar like '%bar'-> truefoobar like '%BAR'-> falsefoobar like 'fooba_'-> truefoobar like 'foobar_'-> falsefoobar like '%ba_'-> trueFor null values and missing values in LIKE operation, the results follows AsterixDB standard:
Reference: CrateDB
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.