This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 48
Fault detection stats #291
Open
amathur1893
wants to merge
4
commits into
opendistro-for-elasticsearch:main
Choose a base branch
from
amathur1893:FaultDetectionStats
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fault detection stats #291
amathur1893
wants to merge
4
commits into
opendistro-for-elasticsearch:main
from
amathur1893:FaultDetectionStats
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+128
to
+131
Coordinator coordinator = (Coordinator) discovery; | ||
Field leaderCheckerField = Coordinator.class.getDeclaredField(LEADER_CHECKER_FIELD); | ||
leaderCheckerField.setAccessible(true); | ||
LeaderChecker leaderChecker = (LeaderChecker) leaderCheckerField.get(coordinator); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this reflection code be refactored outside collectMetrics so that it is run only once?
static { | ||
mapper = new ObjectMapper(); | ||
mapper.setVisibility(PropertyAccessor.FIELD, JsonAutoDetect.Visibility.ANY); | ||
mapper.configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, false); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a specific reason for disabling this?
StringBuilder value = new StringBuilder(); | ||
value.append(PerformanceAnalyzerMetrics.getJsonCurrentMilliSeconds()) | ||
.append(PerformanceAnalyzerMetrics.sMetricNewLineDelimitor); | ||
value.append(faultDetectionMetrics.serialize()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be combined with the previous statement.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes are made in accordance of how we are getting fault detection metrics from ES. Fault Detection metrics in ES will be published in a manner similar to ingest metrics. Hence changing collector and processor accordingly.
Fixes #:
Tmp file
Table created
Contents of the table
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.