-
Notifications
You must be signed in to change notification settings - Fork 176
Disable optimizations for knn library during docker build #384
Disable optimizations for knn library during docker build #384
Conversation
@jmazanec15 could you please test this change with a workflow file. Thanks. |
This reverts commit 3604de6.
@peterzhuamazon Ran test docker build workflow here: 3604de6 Step 4 "Starting ES Docker Build" failed due to credential issue, because I ran the action from my fork, which does not have credentials setup, however, the k-NN library build passed:
Is this acceptable? |
This is good. Thanks! |
Hi! Any trick to have the Docker image from the docker hub working before ODFE1.10.1 is released? Like setting CXXFLAGS env var somewhere... Or is it required to build the image locally? |
Hi @tanguilp ,
Thanks! |
Issue #, if available:
Description of changes:
Remove architecture optimizations during docker build for knn library. Related PR in link above.
Test Results:
https://github.com/jmazanec15/opendistro-build/runs/1097770946?check_suite_focus=true#step:4:1471
Note: If this PR is related to Helm, please also update the README for related documentation changes. Thanks.
https://github.com/opendistro-for-elasticsearch/opendistro-build/blob/master/helm/README.md
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.