This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
support scheduledJob with locks. #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbbaughe
reviewed
Jun 5, 2019
.../com/amazon/opendistroforelasticsearch/jobscheduler/utils/opendistro_job_scheduler_lock.json
Outdated
Show resolved
Hide resolved
.../main/java/com/amazon/opendistroforelasticsearch/jobscheduler/spi/ScheduledJobParameter.java
Outdated
Show resolved
Hide resolved
...a/com/amazon/opendistroforelasticsearch/jobscheduler/sampleextension/SampleJobParameter.java
Outdated
Show resolved
Hide resolved
src/main/java/com/amazon/opendistroforelasticsearch/jobscheduler/JobSchedulerPlugin.java
Outdated
Show resolved
Hide resolved
src/main/java/com/amazon/opendistroforelasticsearch/jobscheduler/utils/LockService.java
Outdated
Show resolved
Hide resolved
src/main/java/com/amazon/opendistroforelasticsearch/jobscheduler/utils/LockService.java
Outdated
Show resolved
Hide resolved
src/main/java/com/amazon/opendistroforelasticsearch/jobscheduler/scheduler/JobScheduler.java
Outdated
Show resolved
Hide resolved
address some minor comment.
dbbaughe
reviewed
Jun 6, 2019
src/main/java/com/amazon/opendistroforelasticsearch/jobscheduler/model/lock/LockModel.java
Outdated
Show resolved
Hide resolved
dbbaughe
reviewed
Jun 6, 2019
src/main/java/com/amazon/opendistroforelasticsearch/jobscheduler/scheduler/JobScheduler.java
Outdated
Show resolved
Hide resolved
dbbaughe
reviewed
Jun 6, 2019
src/main/java/com/amazon/opendistroforelasticsearch/jobscheduler/utils/LockService.java
Outdated
Show resolved
Hide resolved
dbbaughe
reviewed
Jun 6, 2019
src/main/java/com/amazon/opendistroforelasticsearch/jobscheduler/utils/LockService.java
Outdated
Show resolved
Hide resolved
dbbaughe
reviewed
Jun 6, 2019
src/main/java/com/amazon/opendistroforelasticsearch/jobscheduler/utils/LockService.java
Outdated
Show resolved
Hide resolved
1. Move the LockService in the SPI package 1. Added deleteLock to test. 1. Updated naming from job_type to job_index_name 1. updated delete lock to be safe with non existing index name.
|
LGTM thanks for the changes Jinsoo! |
dbbaughe
approved these changes
Jun 7, 2019
...java/com/amazon/opendistroforelasticsearch/jobscheduler/sampleextension/SampleJobRunner.java
Outdated
Show resolved
Hide resolved
spi/src/main/java/com/amazon/opendistroforelasticsearch/jobscheduler/spi/utils/LockService.java
Show resolved
Hide resolved
spi/src/main/java/com/amazon/opendistroforelasticsearch/jobscheduler/spi/utils/LockService.java
Show resolved
Hide resolved
zengyan-amazon
approved these changes
Jun 10, 2019
zengyan-amazon
approved these changes
Jun 10, 2019
dbbaughe
approved these changes
Jun 10, 2019
dbbaughe
pushed a commit
to dbbaughe/job-scheduler
that referenced
this pull request
Feb 6, 2020
* support scheduledJob with locks. * Use ClusterService instead of Client to check the index exists. address some minor comment. * Updated through the comment. 1. Move the LockService in the SPI package 1. Added deleteLock to test. 1. Updated naming from job_type to job_index_name 1. updated delete lock to be safe with non existing index name. * Use ClusterStateService for lockIndexExist * Update acquireLock to take JobParam and JobContext * add some documentation to LockService
dbbaughe
pushed a commit
to dbbaughe/job-scheduler
that referenced
this pull request
Feb 6, 2020
* support scheduledJob with locks. * Use ClusterService instead of Client to check the index exists. address some minor comment. * Updated through the comment. 1. Move the LockService in the SPI package 1. Added deleteLock to test. 1. Updated naming from job_type to job_index_name 1. updated delete lock to be safe with non existing index name. * Use ClusterStateService for lockIndexExist * Update acquireLock to take JobParam and JobContext * add some documentation to LockService
dbbaughe
added a commit
that referenced
this pull request
Feb 20, 2020
* Updated README.md w spelling correction * Uses primary_term/seq_no for job doc versioning * support scheduledJob with locks. (#8) * support scheduledJob with locks. * Use ClusterService instead of Client to check the index exists. address some minor comment. * Updated through the comment. 1. Move the LockService in the SPI package 1. Added deleteLock to test. 1. Updated naming from job_type to job_index_name 1. updated delete lock to be safe with non existing index name. * Use ClusterStateService for lockIndexExist * Update acquireLock to take JobParam and JobContext * add some documentation to LockService * Fixes access denied issue and testing randomly failing because if es test framework * Debian package build * Refactor JobSweeper to do sweep on certain clusterChangedEvent (#10) * Filter clusterChangedEvent when doing sweeping * Format code * Change log level when sweeper already have latest job version (#11) * Update release lock log level * Update sweeper version compare log level * Override equals and hashCode for LockModel (#12) * Adds equals, hashCode, toString overrides to IntervalSchedule and CronSchedule (#13) * Use ROOT Locale for Strings to prevent inconsistencies in format (#14) * update ScheduledJobParser to use the JobDocVersion (#15) * update ScheduledJobParser to use the JobDocVersion * Fixes byte charset default * Add maven publish task for spi (#23) * Add spi subproject maven publish task * Converts lock service to async * Updates lockservice to work in 6.8 * Updates plugin version and updates release notes Co-authored-by: Alolita Sharma <1942529+alolita@users.noreply.github.com> Co-authored-by: Jinsoo <46536764+jinsoor-amzn@users.noreply.github.com> Co-authored-by: Yan Zeng <46499415+zengyan-amazon@users.noreply.github.com> Co-authored-by: Mohammad Qureshi <47198598+qreshi@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support jobs that cannot have overlapping execution at the same time. #7
Description of changes:
Add ScheduledJobs with optional parameter of lock.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.