Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Support ES version 7.6.1 #46

Merged
merged 4 commits into from
Mar 26, 2020
Merged

Support ES version 7.6.1 #46

merged 4 commits into from
Mar 26, 2020

Conversation

bowenlan-amzn
Copy link
Contributor

@bowenlan-amzn bowenlan-amzn commented Mar 20, 2020

Issue #, if available: #47

Description of changes:
Support ES Version 7.6.1

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@bowenlan-amzn
Copy link
Contributor Author

bowenlan-amzn commented Mar 20, 2020

The JDK version in Test and Build Workflow need to be 13 for this version

@bowenlan-amzn bowenlan-amzn changed the title Version 1.6 upgration for ES 7.6.1 Support ES version 7.6.1 Mar 20, 2020
integTest api name change
Copy link
Contributor

@dbbaughe dbbaughe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also upgrade the git workflow file that is causing the CI to fail

sample-extension-plugin/build.gradle Outdated Show resolved Hide resolved
build.gradle Outdated Show resolved Hide resolved
sample-extension-plugin/build.gradle Outdated Show resolved Hide resolved
gradle/wrapper/gradle-wrapper.properties Show resolved Hide resolved
@dbbaughe dbbaughe requested a review from zengyan-amazon March 24, 2020 01:48
1. Fix capitalise
2. Please use “./gradlew wrapper --gradle-version 6.2.2” for consistency
3. upgrade the git workflow to use JDK 13
4. Comment out all @test annotation, use testFooBar as method name is enough
- remove commented dead code
+ release note
Copy link
Member

@zengyan-amazon zengyan-amazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let this change in for now

@dbbaughe dbbaughe merged commit 6f97788 into opendistro-for-elasticsearch:master Mar 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants