Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

new ISM template #383

Merged
merged 26 commits into from
Jan 28, 2021
Merged

new ISM template #383

merged 26 commits into from
Jan 28, 2021

Conversation

bowenlan-amzn
Copy link
Contributor

@bowenlan-amzn bowenlan-amzn commented Jan 12, 2021

Issue #, if available:

Description of changes:
We are gonna remove policyID usage for security reason, so using index template to set policyID to manage index automatically will not be able anymore.

we add this ISM template to be the substitution for previous index template usage.


Bothered by a failing test which caused by Coordinator clear metadata which will be removed in next remove policyID PR, so comment out that test

Change Coordinator to implement ClusterStateListener but not LocalNodeMasterListener. If don't do this, I can see double logs. refer alerting change

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Jan 12, 2021

Codecov Report

Merging #383 (528fb6c) into master (7e598fe) will decrease coverage by 0.17%.
The diff coverage is 79.90%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #383      +/-   ##
============================================
- Coverage     77.48%   77.31%   -0.18%     
- Complexity     1492     1513      +21     
============================================
  Files           194      197       +3     
  Lines          7552     7748     +196     
  Branches       1210     1250      +40     
============================================
+ Hits           5852     5990     +138     
- Misses         1041     1080      +39     
- Partials        659      678      +19     
Impacted Files Coverage Δ Complexity Δ
...agement/indexstatemanagement/ManagedIndexRunner.kt 55.04% <ø> (ø) 41.00 <0.00> (ø)
...ment/indexstatemanagement/util/RestHandlerUtils.kt 100.00% <ø> (ø) 0.00 <0.00> (ø)
...h/indexmanagement/util/IndexManagementException.kt 47.05% <47.05%> (ø) 2.00 <2.00> (?)
...agement/indexstatemanagement/ISMTemplateService.kt 73.80% <73.80%> (ø) 0.00 <0.00> (?)
...nt/indexstatemanagement/ManagedIndexCoordinator.kt 75.37% <79.62%> (+0.54%) 46.00 <7.00> (+9.00)
...dexmanagement/indexstatemanagement/model/Policy.kt 92.22% <80.00%> (-0.55%) 25.00 <2.00> (+1.00) ⬇️
...nagement/indexstatemanagement/model/ISMTemplate.kt 81.57% <81.57%> (ø) 7.00 <7.00> (?)
...t/action/indexpolicy/TransportIndexPolicyAction.kt 76.71% <96.42%> (+10.75%) 4.00 <2.00> (+1.00)
...ch/indexmanagement/elasticapi/ElasticExtensions.kt 81.25% <100.00%> (+1.25%) 0.00 <0.00> (ø)
...dexstatemanagement/elasticapi/ElasticExtensions.kt 92.85% <100.00%> (+4.62%) 0.00 <0.00> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e598fe...33b3544. Read the comment docs.

@bowenlan-amzn bowenlan-amzn marked this pull request as ready for review January 21, 2021 19:20
thalurur
thalurur previously approved these changes Jan 26, 2021
@bowenlan-amzn bowenlan-amzn merged commit c5054c5 into opendistro-for-elasticsearch:master Jan 28, 2021
@bowenlan-amzn bowenlan-amzn deleted the ismtemplate2 branch February 9, 2021 17:21
@bowenlan-amzn bowenlan-amzn added the feature A change that introduce a new unit of functionality of a software system that satisfies a requirem label Feb 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature A change that introduce a new unit of functionality of a software system that satisfies a requirem
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants