This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Adds support for remote https integ tests #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #379 +/- ##
============================================
+ Coverage 76.53% 76.57% +0.04%
Complexity 1462 1462
============================================
Files 188 188
Lines 7335 7335
Branches 1190 1190
============================================
+ Hits 5614 5617 +3
+ Misses 1077 1076 -1
+ Partials 644 642 -2
Continue to review full report at Codecov.
|
qreshi
previously approved these changes
Jan 12, 2021
thalurur
previously approved these changes
Jan 12, 2021
… the shard allocation between nodes is having issues with shards getting moved around as we are trying to force a job to run which causes the job to not run if we get unlucky. Before any job start time gets updated now we first ensure no shards are being moved around.
thalurur
approved these changes
Jan 25, 2021
bowenlan-amzn
approved these changes
Jan 25, 2021
qreshi
reviewed
Jan 25, 2021
| @@ -121,7 +123,7 @@ class RollupRunnerIT : RollupRestTestCase() { | |||
| // Update rollup start time to run second execution | |||
| updateRollupStartTime(rollup) | |||
|
|
|||
| waitFor { | |||
| waitFor(Instant.ofEpochSecond(20)) { | |||
There was a problem hiding this comment.
NP: Can remove these explicit Instant.ofEpochSecond(20) since default timeout of waitFor is now 20 seconds.
qreshi
approved these changes
Jan 25, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
./gradlew integTest -Dtests.rest.cluster=localhost:9200 -Dtests.cluster=localhost:9200 -Dtests.clustername=docker-cluster -Dhttps=true -Duser=admin -Dpassword=adminAdds support for running integ tests against an https/security enabled remote cluster
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.