Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

Adds all rollup REST APIs, updates mappings, adds test resources, ref… #320

Merged
merged 2 commits into from
Nov 12, 2020

Conversation

dbbaughe
Copy link
Contributor

…actors generic utils

Issue #, if available:

Description of changes:
Adds all rollup REST APIs
Updates mappings
Adds test resources
Refactors generic utils

There are some tests that were removed as the runner logic doesn't exist yet, will add those back after

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Nov 12, 2020

Codecov Report

Merging #320 (f150cb2) into master (4dca546) will decrease coverage by 0.13%.
The diff coverage is 72.75%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #320      +/-   ##
============================================
- Coverage     73.90%   73.76%   -0.14%     
- Complexity     1016     1168     +152     
============================================
  Files           139      173      +34     
  Lines          5277     5894     +617     
  Branches        826      898      +72     
============================================
+ Hits           3900     4348     +448     
- Misses          951     1081     +130     
- Partials        426      465      +39     
Impacted Files Coverage Δ Complexity Δ
...ollup/action/mapping/UpdateRollupMappingRequest.kt 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...tion/mapping/TransportUpdateRollupMappingAction.kt 18.96% <18.96%> (ø) 2.00 <2.00> (?)
...nt/rollup/action/stop/TransportStopRollupAction.kt 38.70% <38.70%> (ø) 3.00 <3.00> (?)
.../rollup/action/start/TransportStartRollupAction.kt 47.05% <47.05%> (ø) 3.00 <3.00> (?)
...ent/rollup/action/get/TransportGetRollupsAction.kt 58.06% <58.06%> (ø) 3.00 <3.00> (?)
...lup/action/explain/TransportExplainRollupAction.kt 60.41% <60.41%> (ø) 6.00 <6.00> (?)
...agement/rollup/action/delete/DeleteRollupAction.kt 66.66% <66.66%> (ø) 2.00 <2.00> (?)
...ement/rollup/action/explain/ExplainRollupAction.kt 66.66% <66.66%> (ø) 2.00 <2.00> (?)
...dexmanagement/rollup/action/get/GetRollupAction.kt 66.66% <66.66%> (ø) 2.00 <2.00> (?)
...exmanagement/rollup/action/get/GetRollupsAction.kt 66.66% <66.66%> (ø) 2.00 <2.00> (?)
... and 66 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4dca546...f150cb2. Read the comment docs.

})
}

private fun updateRollupMetadata(rollup: Rollup, actionListener: ActionListener<AcknowledgedResponse>) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we discussed before, we wanted some way for the user to recover from a FAILED metadata status. The state we want to get it into is RETRY since we have logic for those cases in the RollupRunner and RollupMetadataService. If we want to use the _start API as the mechanism for users retrying failed metadata cases, then we can add the logic here to update from FAILED -> RETRY.

This can be made in a separate PR, we'll just want to make sure that there is some mechanism for triggering a retry from the user. We can also review the retry workflow for rollup in general at that time, such as changing _stop to not set to STOPPED if it's in FAILED state as well.

@dbbaughe dbbaughe merged commit 981614b into opendistro-for-elasticsearch:master Nov 12, 2020
@dbbaughe dbbaughe deleted the restapis branch November 12, 2020 22:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants