Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Jenkinsfile params in StreamLit #939

Merged
merged 1 commit into from
Jul 4, 2023
Merged

Fix Jenkinsfile params in StreamLit #939

merged 1 commit into from
Jul 4, 2023

Conversation

BraisVQ
Copy link
Contributor

@BraisVQ BraisVQ commented Jul 4, 2023 •
edited
Loading

Fix provisioning Jenkinsfile params for Streamlit to align with the rest of the quickstarters

@BraisVQ BraisVQ added the skip changelog Skips the changelog enforcer label Jul 4, 2023
@BraisVQ BraisVQ requested a review from sklingel as a code owner July 4, 2023 10:35
@BraisVQ BraisVQ requested a review from gerardcl July 4, 2023 10:36
gerardcl
gerardcl approved these changes Jul 4, 2023
View reviewed changes
Copy link
Member

@gerardcl gerardcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BraisVQ BraisVQ merged commit bf56cb3 into master Jul 4, 2023
@BraisVQ BraisVQ deleted the Streamlit-JenkinsfileParamsFix branch July 4, 2023 13:08
This was referenced Jul 13, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gerardcl gerardcl gerardcl approved these changes

@sklingel sklingel Awaiting requested review from sklingel sklingel is a code owner

Assignees
No one assigned
Labels
skip changelog Skips the changelog enforcer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BraisVQ @gerardcl