Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inf-terraform-aws: remove cloudformation stack from default quickstarter #934

Merged

Conversation

nichtraunzer
Copy link
Member

We experienced that many users forget to remove the Cloudformation stack and its corresponding inspec test. This usually causes issues. Therefore we decided to replace that with a simple region test.

Tasks:

  • Updated documentation in docs/modules/... directory
  • Ran tests in <quickstarter>/testdata directory

@nichtraunzer nichtraunzer changed the title WIP: inf-terraform-aws: remove cloudformation stack from default quickstarter inf-terraform-aws: remove cloudformation stack from default quickstarter Jun 23, 2023
Copy link
Contributor

@tbugfinder tbugfinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM&LGTY

@tbugfinder tbugfinder merged commit 35a7667 into opendevstack:master Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants