Update python agent, pyhon, streamlit and jupyter quickstarters to 3.11 #924

BraisVQ · 2023-05-29T08:36:16Z

Closes #902
Related to #912

Summary:

Add Python 3.11 to agent and update packages.
Update python quickstarter packages and base image to python 3.11.
Update StreamLit quickstarter packages and base image to python 3.11.
Update Jupyter quickstarter packages and base image to python 3.11.

Tests:

Build agent successfully.
New agent allows building successfully with old and new version of Python QS.
Example application for Python QS available for both versions.
New agent allows building successfully with old and new version of Streamlit QS.
Example application for Streamlit QS available for new version.
Current/old version of Streamlit pod fails once build (CrashLoopBackOff)
Example application for Jupyter QS available for new version.
Jupyter Quickstarter does not uses Python agent so no tests needed for it

BraisVQ · 2023-05-29T09:21:18Z

@sklingel @gerardcl I just did a short test and Streamlit fails with the code that we have right now on master branch but not with the update to python 3.11

Traceback (most recent call last):
File "/opt/app-root/bin/streamlit", line 5, in <module>
from streamlit.web.cli import main
File "/opt/app-root/lib64/python3.9/site-packages/streamlit/__init__.py", line 55, in <module>
from streamlit.delta_generator import DeltaGenerator as _DeltaGenerator
File "/opt/app-root/lib64/python3.9/site-packages/streamlit/delta_generator.py", line 43, in <module>
from streamlit.elements.arrow_altair import ArrowAltairMixin
File "/opt/app-root/lib64/python3.9/site-packages/streamlit/elements/arrow_altair.py", line 36, in <module>
from altair.vegalite.v4.api import Chart
ModuleNotFoundError: No module named 'altair.vegalite.v4'

gerardcl · 2023-05-29T13:39:56Z

hi @braisvq1996 ! awesome!! this is great news! 🚀
Regarding the streamlit issue I would assume it is because of missing dependencies with python 3.9 installation? @sklingel we need your help here.
From my side I would suggest to update also any related README and *.adoc where we describe Python components.
Best,

BraisVQ · 2023-05-29T13:42:13Z

hi @braisvq1996 ! awesome!! this is great news! 🚀 Regarding the streamlit issue I would assume it is because of missing dependencies with python 3.9 installation? @sklingel we need your help here. From my side I would suggest to update also any related README and *.adoc where we describe Python components. Best,

With the update to python 3.11 Streamlit application no longer breaks. For the issue in 3.9, I did not investigasted as the main objective here was to update ;)

gerardcl · 2023-05-29T15:01:58Z

docs/modules/quickstarters/pages/be-python-flask.adoc

@@ -115,16 +115,16 @@ The Jenkinsfile is provisioned with this quick starter to ease CI/CD process. In

 This quickstarter uses https://github.com/opendevstack/ods-quickstarters/tree/master/common/jenkins-agents/python[Python] builder agent Jenkins builder agent.

-**NOTE**: The ODS Jenkins Pytnon Agent supports Python versions 3.9, 3.8 and 3.6. See next chapter for further information.
+**NOTE**: The ODS Jenkins Pytnon Agent supports Python versions 3.11, 3.9, 3.8 and 3.6. See next chapter for further information.


I would add here "to avoid/stop using 3.6", or to not even mention it anymore.

gerardcl

LGTM! 🚀

sklingel · 2023-05-30T05:45:19Z

@sklingel @gerardcl I just did a short test and Streamlit fails with the code that we have right now on master branch but not with the update to python 3.11

Traceback (most recent call last):
File "/opt/app-root/bin/streamlit", line 5, in <module>
from streamlit.web.cli import main
File "/opt/app-root/lib64/python3.9/site-packages/streamlit/__init__.py", line 55, in <module>
from streamlit.delta_generator import DeltaGenerator as _DeltaGenerator
File "/opt/app-root/lib64/python3.9/site-packages/streamlit/delta_generator.py", line 43, in <module>
from streamlit.elements.arrow_altair import ArrowAltairMixin
File "/opt/app-root/lib64/python3.9/site-packages/streamlit/elements/arrow_altair.py", line 36, in <module>
from altair.vegalite.v4.api import Chart
ModuleNotFoundError: No module named 'altair.vegalite.v4'

That is really strange, seems like some dependency is broken, when I checked two weeks ago everything was successfully deploying for the promotion test.
Anyway, if it is fixed with python 3.11 I'm more than happy to have this upgrade.

sklingel

LGTM

BraisVQ · 2023-05-30T06:08:12Z

@sklingel @gerardcl I just did a short test and Streamlit fails with the code that we have right now on master branch but not with the update to python 3.11
Traceback (most recent call last):
File "/opt/app-root/bin/streamlit", line 5, in <module>
from streamlit.web.cli import main
File "/opt/app-root/lib64/python3.9/site-packages/streamlit/__init__.py", line 55, in <module>
from streamlit.delta_generator import DeltaGenerator as _DeltaGenerator
File "/opt/app-root/lib64/python3.9/site-packages/streamlit/delta_generator.py", line 43, in <module>
from streamlit.elements.arrow_altair import ArrowAltairMixin
File "/opt/app-root/lib64/python3.9/site-packages/streamlit/elements/arrow_altair.py", line 36, in <module>
from altair.vegalite.v4.api import Chart
ModuleNotFoundError: No module named 'altair.vegalite.v4'
That is really strange, seems like some dependency is broken, when I checked two weeks ago everything was successfully deploying for the promotion test.
Anyway, if it is fixed with python 3.11 I'm more than happy to have this upgrade.

I know that all the tests we did back then we're successful for streamlit with python 3.9
The only thing that might have changed is python version o base image (3.9.6 to 3.9.8 for example)

sklingel · 2023-05-30T07:16:02Z

@sklingel @gerardcl I just did a short test and Streamlit fails with the code that we have right now on master branch but not with the update to python 3.11
Traceback (most recent call last):
File "/opt/app-root/bin/streamlit", line 5, in <module>
from streamlit.web.cli import main
File "/opt/app-root/lib64/python3.9/site-packages/streamlit/__init__.py", line 55, in <module>
from streamlit.delta_generator import DeltaGenerator as _DeltaGenerator
File "/opt/app-root/lib64/python3.9/site-packages/streamlit/delta_generator.py", line 43, in <module>
from streamlit.elements.arrow_altair import ArrowAltairMixin
File "/opt/app-root/lib64/python3.9/site-packages/streamlit/elements/arrow_altair.py", line 36, in <module>
from altair.vegalite.v4.api import Chart
ModuleNotFoundError: No module named 'altair.vegalite.v4'
That is really strange, seems like some dependency is broken, when I checked two weeks ago everything was successfully deploying for the promotion test.
Anyway, if it is fixed with python 3.11 I'm more than happy to have this upgrade.
I know that all the tests we did back then we're successful for streamlit with python 3.9 The only thing that might have changed is python version o base image (3.9.6 to 3.9.8 for example)

Seems like a recent break in streamlit: https://discuss.streamlit.io/t/modulenotfounderror-no-module-named-altair-vegalite-v4/42921/12.
I think rather the upgrade of the streamlit version, than the python version bump fixed it.

BraisVQ and others added 9 commits May 28, 2023 16:52

add python 3.11

ef1b63d

update agent and python qs

42f0b20

modify python package

0e16985

update agent

1d4a9a4

fix

100846f

test new agent

5ffbaa1

fix version

cfc08a8

restore agent

80ef3af

use proper version in qs

a33809e

BraisVQ added enhancement New feature or request maintenance only for maintenance of components labels May 29, 2023

BraisVQ requested review from gerardcl and sklingel May 29, 2023 08:36

BraisVQ added 2 commits May 29, 2023 10:51

update streamlit qs

8a9070a

test streamlit

e0fc187

restore test and update toml file

0d0dfc9

BraisVQ marked this pull request as ready for review May 29, 2023 09:27

BraisVQ requested review from buegelbeatz and henrjk as code owners May 29, 2023 09:27

BraisVQ changed the title ~~Update python agent and QS to 3.11~~ Update python agent and pyhon and streamlit quickstarters to 3.11 May 29, 2023

BraisVQ changed the title ~~Update python agent and pyhon and streamlit quickstarters to 3.11~~ Update python agent, pyhon and streamlit quickstarters to 3.11 May 29, 2023

update Juyter qs and python related documentation

7d49d06

BraisVQ changed the title ~~Update python agent, pyhon and streamlit quickstarters to 3.11~~ Update python agent, pyhon, streamlit and jupyter quickstarters to 3.11 May 29, 2023

add Streamlit to index doc

42dc2b0

gerardcl reviewed May 29, 2023

View reviewed changes

add notice for python on agent and remove from quickstarter

3e4d64e

gerardcl approved these changes May 29, 2023

View reviewed changes

sklingel approved these changes May 30, 2023

View reviewed changes

BraisVQ merged commit b7a9d82 into opendevstack:master May 30, 2023

BraisVQ mentioned this pull request May 30, 2023

Bump flask from 2.2.2 to 2.3.2 in /be-python-flask/files #912

Closed

BraisVQ deleted the feature/python-311 branch June 21, 2023 12:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update python agent, pyhon, streamlit and jupyter quickstarters to 3.11 #924

Update python agent, pyhon, streamlit and jupyter quickstarters to 3.11 #924

BraisVQ commented May 29, 2023 •

edited

Loading

BraisVQ commented May 29, 2023

gerardcl commented May 29, 2023

BraisVQ commented May 29, 2023

gerardcl May 29, 2023

gerardcl left a comment

sklingel commented May 30, 2023

sklingel left a comment

BraisVQ commented May 30, 2023

sklingel commented May 30, 2023

Update python agent, pyhon, streamlit and jupyter quickstarters to 3.11 #924

Update python agent, pyhon, streamlit and jupyter quickstarters to 3.11 #924

Conversation

BraisVQ commented May 29, 2023 • edited Loading

BraisVQ commented May 29, 2023

gerardcl commented May 29, 2023

BraisVQ commented May 29, 2023

gerardcl May 29, 2023

Choose a reason for hiding this comment

gerardcl left a comment

Choose a reason for hiding this comment

sklingel commented May 30, 2023

sklingel left a comment

Choose a reason for hiding this comment

BraisVQ commented May 30, 2023

sklingel commented May 30, 2023

BraisVQ commented May 29, 2023 •

edited

Loading