Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[terraform-agent-2408, inf-terraform-[aws|azure]] feature/version bump 202408 #1036

Merged
merged 29 commits into from
Oct 18, 2024

Conversation

tbugfinder
Copy link
Contributor

@tbugfinder tbugfinder commented Aug 6, 2024

  • bump terraform, ruby versions
  • bump AWS provider version, inspec-aws version
  • bump pre-commit-hooks
  • execute pre-commit-hooks and commit findings
  • add jenkins-agent terraform-2408

Tasks:

  • Updated documentation in docs/modules/... directory
  • Ran tests in <quickstarter>/testdata directory

@tbugfinder tbugfinder force-pushed the feature/version-bump-202408 branch 2 times, most recently from 9fcfdb9 to 50cc3e3 Compare August 6, 2024 20:08
@tbugfinder tbugfinder changed the title WIP: [inf-terraform-aws] feature/version bump 202408 WIP: [inf-terraform-[aws|azure]] feature/version bump 202408 Aug 6, 2024
@tbugfinder tbugfinder requested review from BraisVQ and removed request for metmajer and nichtraunzer August 7, 2024 04:33
@terra-naut

This comment was marked as resolved.

@tbugfinder

This comment was marked as resolved.

@tbugfinder tbugfinder added the enhancement New feature or request label Aug 7, 2024
@tbugfinder tbugfinder requested a review from terra-naut August 10, 2024 12:04
@tbugfinder tbugfinder changed the title WIP: [inf-terraform-[aws|azure]] feature/version bump 202408 [terraform-agent-2408, inf-terraform-[aws|azure]] feature/version bump 202408 Aug 10, 2024
@BraisVQ BraisVQ added the maintenance only for maintenance of components label Aug 20, 2024
@PfurtschellerP
Copy link

Hi @tbugfinder,
would it be possible to add the package genisoimage or a comparable one for iso image generation when running Packer against VMware infrastucture?

@tbugfinder
Copy link
Contributor Author

Hi @tbugfinder, would it be possible to add the package genisoimage or a comparable one for iso image generation when running Packer against VMware infrastucture?

Well, that's doable, would xorriso be okay, as this might be maintained compared to geniosimage?

@tbugfinder tbugfinder force-pushed the feature/version-bump-202408 branch from 4aac341 to 828a585 Compare October 14, 2024 19:51
Copy link

@terra-naut terra-naut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog needs to be fixed. Everything else : great Job

CHANGELOG.md Outdated Show resolved Hide resolved
@terra-naut
Copy link

Hi @tbugfinder, would it be possible to add the package genisoimage or a comparable one for iso image generation when running Packer against VMware infrastucture?

Well, that's doable, would xorriso be okay, as this might be maintained compared to geniosimage?

Has that been resolved via a different channel? I see xorriso in the Dockerfile but no confirmation from @PfurtschellerP

@PfurtschellerP
Copy link

Hi @tbugfinder, would it be possible to add the package genisoimage or a comparable one for iso image generation when running Packer against VMware infrastucture?

Well, that's doable, would xorriso be okay, as this might be maintained compared to geniosimage?

Hi @tbugfinder,
yes that would also be fine.
Thank you!

Copy link

@terra-naut terra-naut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done

Copy link
Contributor

@BraisVQ BraisVQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will do a quick tests to see if everything is ok, approve and merge

inf-terraform-aws/Jenkinsfile.template Show resolved Hide resolved
@BraisVQ BraisVQ merged commit 6450e54 into opendevstack:master Oct 18, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request maintenance only for maintenance of components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants