Feature/147 global cache #460
Conversation
|
I made it a draft PR knowing that there is outstanding work on docs. |
cmd/start/cache.go
Outdated
| return leaveAlone | ||
| } | ||
| return remove // delete everything else | ||
| }, withBaseFileRemover(filepath.Join(fsb.base, odsCacheDirName), fnRemove)) |
There was a problem hiding this comment.
I was wondering if this would be easier to read if the "decider func" would be defined upfront, and only referenced here?
| if err != nil { | ||
| return err | ||
| } | ||
| } |
There was a problem hiding this comment.
I was wondering whether we really need two different ways to deal with directories and files. It seems like fnSkip either returns stuff for directories (walkChildren or leaveAlone), or for files (remove) ... of course fnRemove is called with true/false, but that seems to be for logging purposes only so not sure whether this is worth it.
Anyway, I haven't thought this through and I might be off here ...
There was a problem hiding this comment.
For directories there are three cases:
- Remove directory and (thus skip further walking)
- Skip directory to leave it in place.
- Enter but not delete directory to allow deleting files inside a directory.
For files it only needs to be decided whether they should be removed or not.
Anyways perhaps with improved naming this will be clearer.
cmd/start/cache_test.go
Outdated
| func TestCacheCleaning(t *testing.T) { | ||
|
|
||
| tests := map[string]struct { | ||
| fileSystem fstest.MapFS |
|
The latest pushes did not trigger the workflows. https://www.githubstatus.com/ looks green. |
|
@henrjk I think workflows are not executed when there is a merge conflict. Check if resolving this triggers a execution of the workflows. |
You rock! I didn't know about this and also did not notice the conflict. |
- Do not delete files outside of deps cache. - Remove parameter `cache-dependencies` and always enable it instead. This removes the need for the additional test which was removed. - Some minor stylistic changes - Updated docs
This provides support for caching dependencies by changing
ods-startto no longer clean any content in the working directory and instead spare files under.ods-cache.In addition
ods-startcleans the cache by removing files except at locations.ods-cache/deps/*/**.The PR also introduces parameter
cache-dependenciesdefaulting totrueinods-build-go. The default places the go module cache at.ods-cache/deps/gomodby setting environment variableGOMODCACHEto that area.In addition
ods-build-gonow reports the free disk space.If disk space on the PVC runs out one should replace or resize the PVC to accommodate the storage demands. This is a manual operation.
Compared to the PR #412 this does not implement an additional mechanism to skip dependency caching for a particular (re)build other than changing the parameter
cache-dependencies. As a consequence the mechanism to implement dynamic disablement of caching via file.ods/cache-deps-parent-dirhas not been implemented.Closes #147
Tasks:
docs/designdirectory or not applicabledocsdirectory or not applicablemake test) or not applicable