Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] Compatibility Matrix #140

Closed
wants to merge 19 commits into from

Conversation

wallashss
Copy link

This PR add as documentation a compatibility matrix for mutual exclusive features of vllm

The table bellow shows is a mirror, its purpose is to ease the curation of the table to help double check the incompatible combined features. IMO the cleaner version looks better in the final documentation.

Chunked Prefill APC LoRa Prompt Adapter Speculative decoding CUDA Graphs Encoder/Decoder Logprobs*
Chunked Prefill ❌ [1] ❌ [2] [3] ❌ [8]
APC ❌ [9]
LoRa ❌ [1] ❌ [7] ❌ [10]
Prompt Adapter ❌ [12]
Speculative decoding ❌ [2] [3] ❌ [7] ❌ [11] ❌ [18]
CUDA Graphs ❌ [13]
Encoder/Decoder ❌ [8] ❌ [9] ❌ [10] ❌ [12] ❌ [11] ❌ [13]
Logprobs* ❌ [18]
NVIDIA
CPU ❌ [4] ❌ [5] ❌ [6] ⚠️ ❌ [15] ❌ [17]
AMD ❌ [16]

Copy link

openshift-ci bot commented Sep 2, 2024

Hi @wallashss. Thanks for your PR.

I'm waiting for a opendatahub-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@wallashss
Copy link
Author

BTW, this how the documentation look like rendered.

image

@dtrifiro
Copy link

How about proposing this upstream instead?

@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

openshift-ci bot commented Sep 16, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: wallashss
Once this PR has been reviewed and has the lgtm label, please assign rpancham for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wallashss
Copy link
Author

Proposed to upstream:

vllm-project#8512

@wallashss wallashss closed this Sep 16, 2024
prarit pushed a commit to prarit/vllm that referenced this pull request Oct 18, 2024
* Per @iotamudelta suggestion until the deadlocks issue is better understood
Revert "Make CAR ROCm 6.1 compatible. (opendatahub-io#137)"

This reverts commit 4d2dda6.

* Per @iotamudelta suggestion until the deadlocks issue is better understood
Revert "Optimize custom all reduce (opendatahub-io#130)"

This reverts commit 636ff01.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.