Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

➕ Install peft for prompt adapter support #124

Closed
wants to merge 5 commits into from
Closed

➕ Install peft for prompt adapter support #124

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
197e383
➕ Install peft for prompt adapter support
prashantgupta24 Jul 30, 2024
d6e6f1c
♻️ switch to using uv for pip install
prashantgupta24 Aug 20, 2024
3438634
Merge branch 'main' into prompt-test
prashantgupta24 Aug 20, 2024
c8ec205
Merge branch 'main' into prompt-test
prashantgupta24 Aug 23, 2024
3a2aa42
Merge branch 'main' into prompt-test
prashantgupta24 Sep 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Dockerfile.ubi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,10 @@ RUN --mount=type=cache,target=/root/.cache/pip \
--mount=type=cache,target=/root/.cache/uv \
uv pip install https://github.com/flashinfer-ai/flashinfer/releases/download/v0.1.2/flashinfer-0.1.2+cu121torch2.4-cp311-cp311-linux_x86_64.whl

# Install peft for prompt adapter support
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry if I get back to this, but I just realized this is something which is only supported in the adapter, right? In that case this should be a dependency in vllm-tgis-adapter and not something installed here.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is something that is needed by vllm explicitly -

vllm/vllm/prompt_adapter/models.py

Line 93 in 7a21f52

from peft.utils import load_peft_weights

Copy link
Author

@prashantgupta24 prashantgupta24 Aug 21, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also see these lines within PromptAdapterConfig:

vllm/vllm/config.py

Lines 1334 to 1340 in 7a21f52

library_name = 'peft'
try:
__import__(library_name)
except ImportError as e:
raise ImportError(
f"'{library_name}' is not installed for prompt adapter support."
f"Please install it using 'pip install {library_name}'."

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that this is needed to run the upstream unit tests.

RUN --mount=type=cache,target=/root/.cache/pip \
uv pip install peft==0.12.0

ENV HF_HUB_OFFLINE=1 \
HOME=/home/vllm \
# Allow requested max length to exceed what is extracted from the
Expand Down
Loading