Revert "fix merge_async_iterators usage for vLLM>0.5.4" #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 09290e6. The mandatory `is_cancelled` kwarg was made optional in vllm-project/vllm#7282
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #88 +/- ##
==========================================
- Coverage 61.19% 61.02% -0.17%
==========================================
Files 20 20
Lines 1193 1188 -5
Branches 211 210 -1
==========================================
- Hits 730 725 -5
Misses 387 387
Partials 76 76 ☔ View full report in Codecov by Sentry. |
njhill
approved these changes
Aug 12, 2024
|
I think it should be fine to merge this since the original change was also post-0.5.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 09290e6.
The mandatory
is_cancelledkwarg was made optional in vllm-project/vllm#7282