Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gha: test multiple versions #30

Merged
merged 11 commits into from
Jul 3, 2024
Merged

gha: test multiple versions #30

merged 11 commits into from
Jul 3, 2024

Conversation

dtrifiro
Copy link
Contributor

@dtrifiro dtrifiro commented Jul 2, 2024

  • gha: test multiple vLLM versions
  • tests: use real vLLM version (stop using mocks)
  • grpc_server: only print memory summary for CUDA devices
  • tests: add real tests (for both grpc and http server)
  • enable code coverage

The reason for this:

  1. We can test multiple vLLM version and catch any issues before they hit PyPi
  2. We can test a real vLLM engine by using the CPU executor

@dtrifiro dtrifiro force-pushed the gha-test-multiple-versions branch from cf6fa20 to f9b46cf Compare July 2, 2024 13:52
@dtrifiro dtrifiro force-pushed the gha-test-multiple-versions branch 2 times, most recently from c03070e to f2c2839 Compare July 2, 2024 18:22
@dtrifiro

This comment was marked as outdated.

@dtrifiro dtrifiro force-pushed the gha-test-multiple-versions branch 4 times, most recently from 98fc11e to fd1ec21 Compare July 3, 2024 13:50
@prashantgupta24
Copy link
Contributor

https://github.com/opendatahub-io/vllm-tgis-adapter/blob/main/src/vllm_tgis_adapter/__main__.py#L251

image_input_type was removed here - vllm-project/vllm#5852

@dtrifiro dtrifiro marked this pull request as ready for review July 3, 2024 14:34
@dtrifiro
Copy link
Contributor Author

dtrifiro commented Jul 3, 2024

Handling image input shape issue in #31

@dtrifiro dtrifiro enabled auto-merge July 3, 2024 14:47
@dtrifiro dtrifiro added this pull request to the merge queue Jul 3, 2024
Merged via the queue into main with commit d882a45 Jul 3, 2024
3 checks passed
@dtrifiro dtrifiro deleted the gha-test-multiple-versions branch July 3, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants