fix linter complaints, cleanup gha caching #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtrifiro
commented
Oct 9, 2024
| @@ -73,7 +74,7 @@ jobs: | |||
| uses: actions/cache@v4 | |||
| with: | |||
| path: /home/runner/.nox | |||
| key: ${{ runner.os }}-${{ matrix.pyv }}-${{ hashFiles('noxfile.py') }} | |||
| key: ${{ runner.os }}-python-${{steps.setup-python.outputs.python-version }}-${{ hashFiles('noxfile.py') }} | |||
There was a problem hiding this comment.
Some CI failures seemed to be caused by the fact that the cache was create for python 3.12.6 but actions were setting up the newly released 3.12.7.
Let's use the correct key by using the setup-python action's outputs
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #160 +/- ##
=======================================
Coverage 58.34% 58.35%
=======================================
Files 27 27
Lines 1611 1616 +5
Branches 268 206 -62
=======================================
+ Hits 940 943 +3
+ Misses 582 581 -1
- Partials 89 92 +3 ☔ View full report in Codecov by Sentry. |
dtrifiro
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.