Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix crashes #15

Merged
merged 2 commits into from
Jun 20, 2024
Merged

fix crashes #15

merged 2 commits into from
Jun 20, 2024

Conversation

dtrifiro
Copy link
Contributor

  • fix _convert_output usage:
    ERROR 06-20 15:57:54 grpc_server.py:123] Generate failed
    ERROR 06-20 15:57:54 grpc_server.py:123] Traceback (most recent call last):
    ERROR 06-20 15:57:54 grpc_server.py:123]   File "/opt/vllm/lib64/python3.11/site-packages/vllm_tgis_adapter/grpc/grpc_server.py", line 140, in func_with_log
    ERROR 06-20 15:57:54 grpc_server.py:123]     return await func(*args, **kwargs)
    ERROR 06-20 15:57:54 grpc_server.py:123]            ^^^^^^^^^^^^^^^^^^^^^^^^^^^
    ERROR 06-20 15:57:54 grpc_server.py:123]   File "/opt/vllm/lib64/python3.11/site-packages/vllm_tgis_adapter/grpc/grpc_server.py", line 264, in Generate
    ERROR 06-20 15:57:54 grpc_server.py:123]     response = self._convert_output(
    ERROR 06-20 15:57:54 grpc_server.py:123]                ^^^^^^^^^^^^^^^^^^^^^
    ERROR 06-20 15:57:54 grpc_server.py:123] TypeError: TextGenerationService._convert_output() takes 3 positional arguments but 5 were given
  • fix mypy errors

@dtrifiro dtrifiro merged commit 72cc880 into main Jun 20, 2024
1 check passed
@dtrifiro dtrifiro deleted the fix-crashes branch June 20, 2024 16:09
dtrifiro added a commit that referenced this pull request Jul 2, 2024
@dtrifiro dtrifiro mentioned this pull request Jul 2, 2024
dtrifiro added a commit that referenced this pull request Jul 2, 2024
dtrifiro added a commit that referenced this pull request Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant