Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix nargs + or * #140

Merged
merged 1 commit into from
Sep 24, 2024
Merged

🐛 fix nargs + or * #140

merged 1 commit into from
Sep 24, 2024

Conversation

joerunde
Copy link
Contributor

Thank you @tjohnson31415 for the guidance

Signed-off-by: Joe Runde <Joseph.Runde@ibm.com>
@codecov-commenter
Copy link

codecov-commenter commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 57.18%. Comparing base (5852586) to head (158f02a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/vllm_tgis_adapter/tgis_utils/args.py 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #140      +/-   ##
==========================================
- Coverage   57.26%   57.18%   -0.08%     
==========================================
  Files          25       25              
  Lines        1542     1544       +2     
  Branches      256      257       +1     
==========================================
  Hits          883      883              
- Misses        581      582       +1     
- Partials       78       79       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@njhill njhill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @joerunde

@joerunde joerunde merged commit 9031668 into main Sep 24, 2024
3 checks passed
@joerunde joerunde deleted the nargs-fix branch September 24, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants