[model server] Add Model mesh tensorflow test and enable openvino auth test #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following are automatically added/executed:
Available user actions:
Supported labels{'/verified', '/hold', '/lgtm', '/wip'} |
mwaykole
approved these changes
Jan 28, 2025
|
/lgtm |
lugi0
reviewed
Jan 28, 2025
Comment on lines
+165
to
+172
| @pytest.fixture(scope="class") | ||
| def modelmesh_management_state(dsc_resource: DataScienceCluster) -> str: | ||
| return dsc_resource.instance.spec.components[DscComponents.MODELMESHSERVING].managementState | ||
|
|
||
|
|
||
| @pytest.fixture(scope="class") | ||
| def kserve_management_state(dsc_resource: DataScienceCluster) -> str: | ||
| return dsc_resource.instance.spec.components[DscComponents.KSERVE].managementState |
There was a problem hiding this comment.
I'd prefer to have a single function/fixture that returns the management state for any component, I don't see the benefit in having to write the same one line function for each component
There was a problem hiding this comment.
removed the fixtures, calling directly where needed
Comment on lines
+35
to
+42
| for component_name, desired_state in components.items(): | ||
| if (orig_state := dsc_components[component_name].managementState) != desired_state: | ||
| dsc_dict.setdefault("spec", {}).setdefault("components", {})[component_name] = { | ||
| "managementState": desired_state | ||
| } | ||
| component_to_reconcile[component_name] = orig_state | ||
| else: | ||
| LOGGER.warning(f"Component {component_name} was already set to managementState {desired_state}") |
There was a problem hiding this comment.
I don't really understand what you're trying to do here, can't we use ResourceEditor directly?
There was a problem hiding this comment.
using resource editor - passing a dict with all required changes to all componenets. this for populates the dict
mwaykole
pushed a commit
to mwaykole/opendatahub-tests
that referenced
this pull request
Jan 29, 2025
…h test (opendatahub-io#102) * Create size-labeler.yml * Delete .github/workflows/size-labeler.yml * add model mesh tests * add model mesh tests * add model mesh tests * update code * increase timeout * add fixtures to enabe kserve modelmesh * add fixtures to enabe kserve modelmesh * add fixtures to enabe kserve modelmesh * add fixtures to enabe kserve modelmesh * update scope * update scope * add service mesh * remove unused xitures * update model registry type in dsc * fix kserve type and remove check # Conflicts: # tests/model_serving/model_server/utils.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
How Has This Been Tested?
Merge criteria: