Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(kserve): automates installation and configuration of KServe prerequisites #691
feat(kserve): automates installation and configuration of KServe prerequisites #691
Changes from 1 commit
1d7055f
b971312
82b9ba5
4be6c25
470168d
cbc6d32
6e7642b
394b575
882ea26
343f666
f77c763
4b5b005
9b75b63
d753b4d
a13df5b
b089fd6
d384afe
2805355
bbeef9e
364b743
61fa9ff
a04fda3
036abed
723b9d6
503e2d8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://docs.google.com/document/d/1A3la5Zg93RcvYk6HW08VKxHbtbEoDZNablEOUwahPmo/edit#heading=h.eb02e5dvc38p according to this doc,
for clean install of operator, we will get kserve by default Managaed,
so i think we should have Serverless and ServiceMesh by default set to Managed than Removed
FYI @israel-hdez @bartoszmajsak
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not very in favor of enabling these components by default, since these can have an important impact on the cluster.
Yet, if the consensus tells that it would be safe, I think we can do it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zdtsw I think default here refers to if nothing is set, it will be set to
Removed
. This is same as all other components. We can update our default DSCI CR to set these components toManaged
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@VaishnaviHire @zdtsw it applies to most of the things here so it's not a comment for this particular PR... the way we use states now makes enum and pattern not matching each other. I wonder which takes precedence here and if we shouldn't align it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the old plan was to not have enum in the end when we implemented Unmanaged (not sure if we will need Force or not in long term) but since we do not want user be able to put Unmanaged or Force for the time being, we added enum to force with 2 options.
My personal opinion: once logic for Unmanaged is done, we can remove enum