Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: missing odh-admins group #535

Merged

Conversation

zdtsw
Copy link
Member

@zdtsw zdtsw commented Sep 14, 2023

Description

we do not have odh-admins group created automatically, and this has an error in dashboard

How Has This Been Tested?

local test:quay.io/wenzhou/opendatahub-operator-catalog:v2.1.666

before:
Screenshot from 2023-09-14 14-12-42

AFter
Screenshot from 2023-09-14 14-21-33
Screenshot from 2023-09-14 14-24-10

Merge criteria:

  • The commits are squashed in a cohesive manner and have meaningful messages.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Signed-off-by: Wen Zhou <wenzhou@redhat.com>
@zdtsw zdtsw requested review from VaishnaviHire and removed request for VaishnaviHire September 14, 2023 12:27
@zdtsw
Copy link
Member Author

zdtsw commented Sep 14, 2023

/test opendatahub-operator-e2e

Copy link
Member

@VaishnaviHire VaishnaviHire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Sep 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: VaishnaviHire

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 461faa8 into opendatahub-io:main Sep 14, 2023
5 checks passed
VaishnaviHire pushed a commit to VaishnaviHire/opendatahub-operator that referenced this pull request Sep 29, 2023
Signed-off-by: Wen Zhou <wenzhou@redhat.com>
(cherry picked from commit 461faa8)
VaishnaviHire pushed a commit to VaishnaviHire/opendatahub-operator that referenced this pull request Sep 29, 2023
Signed-off-by: Wen Zhou <wenzhou@redhat.com>
(cherry picked from commit 461faa8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants