Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] [RHOAIENG-19278] Custom namespace field for workbenches #1704

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

robotmaxtron
Copy link

Description

Exposes a new field in the DSC for Workbenches, allowing for the configuration of the namespace during component enablement.

https://issues.redhat.com/browse/RHOAIENG-19278

How Has This Been Tested?

Built and deployed the image to a 4.17 cluster and used the namespace custom-wb-ns for the new field. The workbench component shows ready and is visible in the spec.

Screenshot or short clip

oc describe dsc
Name:         default
Namespace:
Labels:       <none>
Annotations:  <none>
API Version:  datasciencecluster.opendatahub.io/v1
Kind:         DataScienceCluster
Metadata:
  Creation Timestamp:  2025-02-28T14:20:59Z
  Generation:          1
  Resource Version:    23014527
  UID:                 1764e67e-7297-4f01-9e70-87722b2e4748
Spec:
  Components:
    Codeflare:
      Management State:  Removed
    Dashboard:
      Management State:  Managed
    Datasciencepipelines:
      Management State:  Managed
    Feastoperator:
    Kserve:
      Management State:  Removed
      Nim:
        Management State:  Managed
      Serving:
        Ingress Gateway:
          Certificate:
            Type:          OpenshiftDefaultIngress
        Management State:  Managed
        Name:              knative-serving
    Kueue:
    Modelmeshserving:
      Management State:  Managed
    Modelregistry:
      Registries Namespace:  odh-model-registries
    Ray:
      Management State:  Removed
    Trainingoperator:
    Trustyai:
    Workbenches:
      Management State:     Managed
      Workbench Namespace:  custom-wb-ns

Merge criteria

  • You have read the contributors guide.
  • Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
  • Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Copy link

openshift-ci bot commented Feb 28, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from robotmaxtron. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@robotmaxtron robotmaxtron changed the title [DRAFT] [RHOAIENG-18422] Custom namespace field for workbenches [DRAFT] [RHOAIENG-19278] Custom namespace field for workbenches Feb 28, 2025
Copy link
Contributor

This PR can't be merged just yet 😢

Please run make generate manifests api-docs and commit the changes.

For more info: https://github.com/opendatahub-io/opendatahub-operator/actions/runs/13590809946

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant