Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e(components): ensure components are turned off at the end of the related test suite #1692

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

lburgazzoli
Copy link
Contributor

Description

How Has This Been Tested?

Screenshot or short clip

Merge criteria

  • You have read the contributors guide.
  • Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
  • Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

@openshift-ci openshift-ci bot requested review from jackdelahunt and zdtsw February 25, 2025 13:58
@zdtsw
Copy link
Member

zdtsw commented Feb 25, 2025

was any problem caused by the old order?

@lburgazzoli
Copy link
Contributor Author

was any problem caused by the old order?

Since it lefts come components running, you may hit a cluster capacity (i.e. in my local CRC) and then some tests would fail because come components won't become ready

Copy link

codecov bot commented Feb 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 22.00%. Comparing base (65ff623) to head (bee83a9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1692   +/-   ##
=======================================
  Coverage   22.00%   22.00%           
=======================================
  Files         168      168           
  Lines       11365    11365           
=======================================
  Hits         2501     2501           
  Misses       8606     8606           
  Partials      258      258           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

openshift-ci bot commented Feb 25, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zdtsw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 6e4594f into opendatahub-io:main Feb 25, 2025
10 checks passed
@lburgazzoli lburgazzoli deleted the e2e-cleanup branch February 25, 2025 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants