[Sync] changes from main #1607
Merged
[Sync] changes from main #1607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ub-io#1540) This reduce the direct dependency from Monitoring to DSCI (cherry picked from commit 5321b8c)
The Monitoring controller is initialized only when the platform is managed, hence there's no need to conditionally add manifests (cherry picked from commit 21eba1b)
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## rhoai #1607 +/- ##
==========================================
+ Coverage 20.01% 20.02% +0.01%
==========================================
Files 160 160
Lines 10982 10976 -6
==========================================
Hits 2198 2198
+ Misses 8549 8543 -6
Partials 235 235 ☔ View full report in Codecov by Sentry. |
CFSNM
approved these changes
Feb 3, 2025
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CFSNM The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test opendatahub-operator-e2e |
openshift-merge-bot
bot
merged commit dd44dcd
into
opendatahub-io:rhoai
10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
How Has This Been Tested?
Screenshot or short clip
Merge criteria