Update Go version in go.mod to 1.22 (Go 1.22: 2/3) #1439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
grdryn
changed the title
|
/hold wait for #1424 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1439 +/- ##
=======================================
Coverage ? 19.71%
=======================================
Files ? 149
Lines ? 10052
Branches ? 0
=======================================
Hits ? 1982
Misses ? 7846
Partials ? 224 ☔ View full report in Codecov by Sentry. |
5 tasks
JIRA: https://issues.redhat.com/browse/RHOAIENG-16819 The UBI8 go-toolset image that we use for building is already on 1.22, so I don't think there's any reason to remain bound to 1.21. Also, upstream Go only support the two most recent minor versions: currently that means 1.23 and 1.22; 1.21 is no longer receiving any updates from the Go developers.
JIRA: https://issues.redhat.com/browse/RHOAIENG-16819 This just updates the Go version in the go directive in go.mod. The code changes to add nolint suppression is temporary and those will be addressed in a separate commit.
ykaliuta
approved these changes
Dec 11, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ykaliuta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/unhold |
openshift-merge-bot
bot
merged commit 5f456ad
into
opendatahub-io:main
10 checks passed
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://issues.redhat.com/browse/RHOAIENG-16819
This PR is stacked upon #1424. That PR should be merged first.
Reviewstack may be a good way to review just the changes in this PR:
https://reviewstack.dev/opendatahub-io/opendatahub-operator/pull/1439
Description
This just updates the Go version in the go directive in go.mod. The code changes to add nolint suppression is temporary and those will be addressed in a separate commit.
How Has This Been Tested?
Screenshot or short clip
Merge criteria