Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old component interface #1433

Merged

Conversation

lburgazzoli
Copy link
Contributor

@lburgazzoli lburgazzoli commented Dec 8, 2024

  • old and unused Component interface removed
  • UpdatePrometheusConfig function moved to pkg/services/monitoring

Description

How Has This Been Tested?

Screenshot or short clip

Merge criteria

  • You have read the contributors guide.
  • Commit messages are meaningful - have a clear and concise summary and detailed explanation of what was changed and why.
  • Pull Request contains a description of the solution, a link to the JIRA issue, and to any dependent or related Pull Request.
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work

Copy link
Contributor

github-actions bot commented Dec 8, 2024

This PR can't be merged just yet 😢

Please run make generate manifests api-docs and commit the changes.

For more info: https://github.com/opendatahub-io/opendatahub-operator/actions/runs/12223852117

@lburgazzoli lburgazzoli force-pushed the cleanup-old-components branch from 89dbecc to 08c2dff Compare December 8, 2024 17:32
@lburgazzoli
Copy link
Contributor Author

/retest

1 similar comment
@lburgazzoli
Copy link
Contributor Author

/retest

@zdtsw
Copy link
Member

zdtsw commented Dec 9, 2024

/retest-required

@zdtsw
Copy link
Member

zdtsw commented Dec 9, 2024

@openshift-ci openshift-ci bot removed the lgtm label Dec 9, 2024
@lburgazzoli
Copy link
Contributor Author

@openshift-ci openshift-ci bot added the lgtm label Dec 9, 2024
Copy link

openshift-ci bot commented Dec 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zdtsw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@VaishnaviHire
Copy link
Member

/lgtm

Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@1adbbfd). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1433   +/-   ##
=======================================
  Coverage        ?   25.57%           
=======================================
  Files           ?       67           
  Lines           ?     5526           
  Branches        ?        0           
=======================================
  Hits            ?     1413           
  Misses          ?     3940           
  Partials        ?      173           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lburgazzoli
Copy link
Contributor Author

/test opendatahub-operator-e2e

@lburgazzoli
Copy link
Contributor Author

/test opendatahub-operator-e2e

1 similar comment
@lburgazzoli
Copy link
Contributor Author

/test opendatahub-operator-e2e

- old and unused Component interface removed
- UpdatePrometheusConfig function moved to pkg/services/monitoring
@lburgazzoli lburgazzoli force-pushed the cleanup-old-components branch from a227215 to 4ec80ab Compare December 9, 2024 15:49
@openshift-ci openshift-ci bot removed the lgtm label Dec 9, 2024
Copy link
Member

@VaishnaviHire VaishnaviHire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Dec 9, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit f9a2b9b into opendatahub-io:main Dec 9, 2024
10 checks passed
@lburgazzoli lburgazzoli deleted the cleanup-old-components branch December 9, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants