-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove old component interface #1433
Remove old component interface #1433
Conversation
This PR can't be merged just yet 😢Please run For more info: https://github.com/opendatahub-io/opendatahub-operator/actions/runs/12223852117 |
89dbecc
to
08c2dff
Compare
/retest |
1 similar comment
/retest |
/retest-required |
done |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zdtsw The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1433 +/- ##
=======================================
Coverage ? 25.57%
=======================================
Files ? 67
Lines ? 5526
Branches ? 0
=======================================
Hits ? 1413
Misses ? 3940
Partials ? 173 ☔ View full report in Codecov by Sentry. |
/test opendatahub-operator-e2e |
/test opendatahub-operator-e2e |
1 similar comment
/test opendatahub-operator-e2e |
- old and unused Component interface removed - UpdatePrometheusConfig function moved to pkg/services/monitoring
a227215
to
4ec80ab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Description
How Has This Been Tested?
Screenshot or short clip
Merge criteria
Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).The developer has manually tested the changes and verified that the changes work