Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DO NOT MERGE This deletes the kustomize folder to enable multiple kfdef installs #14

Closed
wants to merge 1 commit into from

Conversation

nakfour
Copy link

@nakfour nakfour commented Apr 29, 2020

This is a temporary fix to solve #9

  1. git clone this branch
  2. Build the operator
   make -d build-operator
   cp build/_output/bin/opendatahub-operator build/_output/bin/kfctl
   make -d build-operator
   make push-operator
  1. Follow the instructions to install the operator found here: https://github.com/nakfour/opendatahub-operator/blob/master/operator.md

  2. Create different kfdefs in different namespaces

// This is temp. fix to allow users to install multiple kfdefs
if action == "apply" {
// Delete kustomize folder
reqLogger.Info("Deleting kustomize Folder")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would recommend to move the deletion code into kfApply function and check for the /tmp/kustomize existence so that we avoid printing the error on first apply

@vpavlin
Copy link
Contributor

vpavlin commented Apr 30, 2020

This looks like a reasonable workaround until Adrian provides the proper fix..just one comment above on the code location and logic

@LaVLaS
Copy link
Contributor

LaVLaS commented May 14, 2020

@nakfour Is this resolved after we updated the master branch?

@nakfour nakfour changed the title This deletes the kustomize folder to enable multiple kfdef installs DO NOT MERGE This deletes the kustomize folder to enable multiple kfdef installs May 18, 2020
@vpavlin
Copy link
Contributor

vpavlin commented May 19, 2020

The master got rebased, I believe this can be closed

@vpavlin vpavlin closed this May 19, 2020
LaVLaS pushed a commit to LaVLaS/opendatahub-operator that referenced this pull request Jul 16, 2021
VaishnaviHire referenced this pull request in VaishnaviHire/opendatahub-operator Aug 1, 2023
Add Authentication overlay for dashboard
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants